diff options
| author | Julia Lawall | 2008-04-28 11:16:09 +0200 |
|---|---|---|
| committer | Linus Torvalds | 2008-04-28 17:58:44 +0200 |
| commit | 269b26191650be46ce6c91dec24cf20f59650529 (patch) | |
| tree | 9ff8863d02d709dcb75deef345b3a6eb8c0d30c0 | |
| parent | ext3: check ext3_journal_get_write_access() errors (diff) | |
| download | kernel-qcow2-linux-269b26191650be46ce6c91dec24cf20f59650529.tar.gz kernel-qcow2-linux-269b26191650be46ce6c91dec24cf20f59650529.tar.xz kernel-qcow2-linux-269b26191650be46ce6c91dec24cf20f59650529.zip | |
fs/ext3: use BUG_ON
if (...) BUG(); should be replaced with BUG_ON(...) when the test has no
side-effects to allow a definition of BUG_ON that drops the code completely.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@ disable unlikely @ expression E,f; @@
(
if (<... f(...) ...>) { BUG(); }
|
- if (unlikely(E)) { BUG(); }
+ BUG_ON(E);
)
@@ expression E,f; @@
(
if (<... f(...) ...>) { BUG(); }
|
- if (E) { BUG(); }
+ BUG_ON(E);
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | fs/ext3/balloc.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c index da0cb2c0e437..dd4237e5e9ec 100644 --- a/fs/ext3/balloc.c +++ b/fs/ext3/balloc.c @@ -232,8 +232,7 @@ restart: prev = rsv; } printk("Window map complete.\n"); - if (bad) - BUG(); + BUG_ON(bad); } #define rsv_window_dump(root, verbose) \ __rsv_window_dump((root), (verbose), __FUNCTION__) |