diff options
| author | Wenwen Wang | 2019-08-15 22:29:51 +0200 |
|---|---|---|
| committer | David S. Miller | 2019-08-18 23:11:28 +0200 |
| commit | 44ef3a03252844a8753479b0cea7f29e4a804bdc (patch) | |
| tree | a57a078b5ee773603881dabf87ae9dfac30740f9 | |
| parent | net: cavium: fix driver name (diff) | |
| download | kernel-qcow2-linux-44ef3a03252844a8753479b0cea7f29e4a804bdc.tar.gz kernel-qcow2-linux-44ef3a03252844a8753479b0cea7f29e4a804bdc.tar.xz kernel-qcow2-linux-44ef3a03252844a8753479b0cea7f29e4a804bdc.zip | |
wimax/i2400m: fix a memory leak bug
In i2400m_barker_db_init(), 'options_orig' is allocated through kstrdup()
to hold the original command line options. Then, the options are parsed.
However, if an error occurs during the parsing process, 'options_orig' is
not deallocated, leading to a memory leak bug. To fix this issue, free
'options_orig' before returning the error.
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/wimax/i2400m/fw.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/wimax/i2400m/fw.c b/drivers/net/wimax/i2400m/fw.c index e9fc168bb734..489cba9b284d 100644 --- a/drivers/net/wimax/i2400m/fw.c +++ b/drivers/net/wimax/i2400m/fw.c @@ -351,13 +351,15 @@ int i2400m_barker_db_init(const char *_options) } result = i2400m_barker_db_add(barker); if (result < 0) - goto error_add; + goto error_parse_add; } kfree(options_orig); } return 0; +error_parse_add: error_parse: + kfree(options_orig); error_add: kfree(i2400m_barker_db); return result; |