summaryrefslogtreecommitdiffstats
path: root/arch/um/drivers/xterm.c
diff options
context:
space:
mode:
authorJeff Dike2007-07-16 08:38:56 +0200
committerLinus Torvalds2007-07-16 18:05:38 +0200
commitc43990162fc7f9d2f15a12797fdc6f9c0905f704 (patch)
tree64f8b776c4807da48971f3c24ca157c5e6ab921f /arch/um/drivers/xterm.c
parentuml: SIGIO support cleanup (diff)
downloadkernel-qcow2-linux-c43990162fc7f9d2f15a12797fdc6f9c0905f704.tar.gz
kernel-qcow2-linux-c43990162fc7f9d2f15a12797fdc6f9c0905f704.tar.xz
kernel-qcow2-linux-c43990162fc7f9d2f15a12797fdc6f9c0905f704.zip
uml: simplify helper stack handling
run_helper and run_helper_thread had arguments which were the same in all callers. run_helper's stack_out was always NULL and run_helper_thread's stack_order was always 0. These are now gone, and the constants folded into the code. Also fixed leaks of the helper stack in the AIO and SIGIO code. Signed-off-by: Jeff Dike <jdike@linux.intel.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/um/drivers/xterm.c')
-rw-r--r--arch/um/drivers/xterm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/um/drivers/xterm.c b/arch/um/drivers/xterm.c
index 35912846ed21..fd817e541543 100644
--- a/arch/um/drivers/xterm.c
+++ b/arch/um/drivers/xterm.c
@@ -132,7 +132,7 @@ static int xterm_open(int input, int output, int primary, void *d,
}
sprintf(title, data->title, data->device);
- pid = run_helper(NULL, NULL, argv, NULL);
+ pid = run_helper(NULL, NULL, argv);
if (pid < 0) {
err = pid;
printk(UM_KERN_ERR "xterm_open : run_helper failed, "