diff options
| author | Matias Bjørling | 2014-06-11 23:43:54 +0200 |
|---|---|---|
| committer | Jens Axboe | 2014-06-11 23:53:39 +0200 |
| commit | 28747fcd2211d0fccbe3d3c91a1067c3744db908 (patch) | |
| tree | 810f1f10310d3ec6f30aebf0be1b8a1964da58fc /block | |
| parent | null_blk: fix name and description of 'queue_mode' module parameter (diff) | |
| download | kernel-qcow2-linux-28747fcd2211d0fccbe3d3c91a1067c3744db908.tar.gz kernel-qcow2-linux-28747fcd2211d0fccbe3d3c91a1067c3744db908.tar.xz kernel-qcow2-linux-28747fcd2211d0fccbe3d3c91a1067c3744db908.zip | |
block: remove WQ_POWER_EFFICIENT from kblockd
blk-mq issues async requests through kblockd. To issue a work request on
a specific CPU, kblockd_schedule_delayed_work_on is used. However, the
specific CPU choice may not be honored, if the power_efficient option
for workqueues is set. blk-mq requires that we have strict per-cpu
scheduling, so it wont work properly if kblockd is marked
POWER_EFFICIENT and power_efficient is set.
Remove the kblockd WQ_POWER_EFFICIENT flag to prevent this behavior.
This essentially reverts part of commit 695588f9454b, which added
the WQ_POWER_EFFICIENT marker to kblockd.
Signed-off-by: Matias Bjørling <m@bjorling.me>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'block')
| -rw-r--r-- | block/blk-core.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/block/blk-core.c b/block/blk-core.c index 9aca8c71e70b..55f91b88bb14 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -3311,8 +3311,7 @@ int __init blk_dev_init(void) /* used for unplugging and affects IO latency/throughput - HIGHPRI */ kblockd_workqueue = alloc_workqueue("kblockd", - WQ_MEM_RECLAIM | WQ_HIGHPRI | - WQ_POWER_EFFICIENT, 0); + WQ_MEM_RECLAIM | WQ_HIGHPRI, 0); if (!kblockd_workqueue) panic("Failed to create kblockd\n"); |