diff options
| author | Mike Snitzer | 2018-03-30 05:31:32 +0200 |
|---|---|---|
| committer | Mike Snitzer | 2018-03-30 05:31:32 +0200 |
| commit | da5dadb4f11660ca67580cd4a7420161266d6254 (patch) | |
| tree | 6dacbd021d8c2d9f494aab81ee8a095fc22664ea /block | |
| parent | dm mpath: fix support for loading scsi_dh modules during table load (diff) | |
| download | kernel-qcow2-linux-da5dadb4f11660ca67580cd4a7420161266d6254.tar.gz kernel-qcow2-linux-da5dadb4f11660ca67580cd4a7420161266d6254.tar.xz kernel-qcow2-linux-da5dadb4f11660ca67580cd4a7420161266d6254.zip | |
dm: fix dropped return code from dm_get_bdev_for_ioctl
dm_get_bdev_for_ioctl()'s return of 0 or 1 must be the result from
prepare_ioctl (1 means the ioctl was issued to a partition, 0 means it
wasn't). Unfortunately commit 519049afea ("dm: use blkdev_get rather
than bdgrab when issuing pass-through ioctl") reused the variable 'r'
to store the return from blkdev_get() that follows prepare_ioctl()
-- whereby dropping prepare_ioctl()'s result on the floor.
This can lead to an ioctl or persistent reservation being issued to a
partition going unnoticed, which implies the extra permission check for
CAP_SYS_RAWIO is skipped.
Fix this by using a different variable to store blkdev_get()'s return.
Fixes: 519049afea ("dm: use blkdev_get rather than bdgrab when issuing pass-through ioctl")
Reported-by: Alasdair G Kergon <agk@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions