diff options
| author | Lucas De Marchi | 2018-05-23 20:04:35 +0200 |
|---|---|---|
| committer | Ville Syrjälä | 2018-06-21 17:55:35 +0200 |
| commit | 8a29c778fa1a50a25a3e66cf9589888758858d24 (patch) | |
| tree | 0105cbf3afda18bbbba22d809e9cfe937cdf9d8a /drivers/gpu/drm/i915/i915_drv.c | |
| parent | drm/i915: Redefine EINVAL for debugging (diff) | |
| download | kernel-qcow2-linux-8a29c778fa1a50a25a3e66cf9589888758858d24.tar.gz kernel-qcow2-linux-8a29c778fa1a50a25a3e66cf9589888758858d24.tar.xz kernel-qcow2-linux-8a29c778fa1a50a25a3e66cf9589888758858d24.zip | |
drm/i915: remove check for aux irq
This became dead code with commit 309bd8ed464f ("drm/i915: Reinstate
GMBUS and AUX interrupts on gen4/g4x").
v2: Move comment about HW behavior to where decision is made to enable
MSI (Ville).
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180523180435.18042-1-lucas.demarchi@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/i915_drv.c')
| -rw-r--r-- | drivers/gpu/drm/i915/i915_drv.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 33453d56c386..2959c88a37a5 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -1165,6 +1165,12 @@ static int i915_driver_init_hw(struct drm_i915_private *dev_priv) * get lost on g4x as well, and interrupt delivery seems to stay * properly dead afterwards. So we'll just disable them for all * pre-gen5 chipsets. + * + * dp aux and gmbus irq on gen4 seems to be able to generate legacy + * interrupts even when in MSI mode. This results in spurious + * interrupt warnings if the legacy irq no. is shared with another + * device. The kernel then disables that interrupt source and so + * prevents the other device from working properly. */ if (INTEL_GEN(dev_priv) >= 5) { if (pci_enable_msi(pdev) < 0) |