summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/i915_gem_stolen.c
diff options
context:
space:
mode:
authorChris Wilson2017-01-30 14:47:21 +0100
committerChris Wilson2017-01-31 12:19:23 +0100
commit1692cd60d999b00a0491692dab0286e6011abd36 (patch)
tree6ca4aad3e28794cb99b9bdc28dfa993054b6c5f1 /drivers/gpu/drm/i915/i915_gem_stolen.c
parentdrm/i915: Treat stolen memory as DMA addresses (diff)
downloadkernel-qcow2-linux-1692cd60d999b00a0491692dab0286e6011abd36.tar.gz
kernel-qcow2-linux-1692cd60d999b00a0491692dab0286e6011abd36.tar.xz
kernel-qcow2-linux-1692cd60d999b00a0491692dab0286e6011abd36.zip
drm/i915: Sanity check the computed size and base of stolen memory
Just do a quick check that the stolen memory address range doesn't overflow our chosen integer type. v2: Add add_overflows() to utils with the promise that gcc7 can do this better than C and then maybe it will have a proper definition in core. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/20170130134721.5159-1-chris@chris-wilson.co.uk Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Diffstat (limited to 'drivers/gpu/drm/i915/i915_gem_stolen.c')
-rw-r--r--drivers/gpu/drm/i915/i915_gem_stolen.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c
index a75de8c6ece0..cba12ee90cbf 100644
--- a/drivers/gpu/drm/i915/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
@@ -189,7 +189,7 @@ static dma_addr_t i915_stolen_to_dma(struct drm_i915_private *dev_priv)
base = tom - tseg_size - ggtt->stolen_size;
}
- if (base == 0)
+ if (base == 0 || add_overflows(base, ggtt->stolen_size))
return 0;
/* make sure we don't clobber the GTT if it's within stolen memory */