diff options
| author | Lorenzo Stoakes | 2016-10-13 02:20:17 +0200 |
|---|---|---|
| committer | Linus Torvalds | 2016-10-19 17:12:02 +0200 |
| commit | 9beae1ea89305a9667ceaab6d0bf46a045ad71e7 (patch) | |
| tree | 32df9181fe7354a3ea2d4cdc8e852a072f2a2346 /drivers/gpu/drm/i915/i915_gem_userptr.c | |
| parent | mm: replace get_user_pages() write/force parameters with gup_flags (diff) | |
| download | kernel-qcow2-linux-9beae1ea89305a9667ceaab6d0bf46a045ad71e7.tar.gz kernel-qcow2-linux-9beae1ea89305a9667ceaab6d0bf46a045ad71e7.tar.xz kernel-qcow2-linux-9beae1ea89305a9667ceaab6d0bf46a045ad71e7.zip | |
mm: replace get_user_pages_remote() write/force parameters with gup_flags
This removes the 'write' and 'force' from get_user_pages_remote() and
replaces them with 'gup_flags' to make the use of FOLL_FORCE explicit in
callers as use of this flag can result in surprising behaviour (and
hence bugs) within the mm subsystem.
Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/gpu/drm/i915/i915_gem_userptr.c')
| -rw-r--r-- | drivers/gpu/drm/i915/i915_gem_userptr.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/i915_gem_userptr.c b/drivers/gpu/drm/i915/i915_gem_userptr.c index e537930c64b5..c6f780f5abc9 100644 --- a/drivers/gpu/drm/i915/i915_gem_userptr.c +++ b/drivers/gpu/drm/i915/i915_gem_userptr.c @@ -508,6 +508,10 @@ __i915_gem_userptr_get_pages_worker(struct work_struct *_work) pvec = drm_malloc_gfp(npages, sizeof(struct page *), GFP_TEMPORARY); if (pvec != NULL) { struct mm_struct *mm = obj->userptr.mm->mm; + unsigned int flags = 0; + + if (!obj->userptr.read_only) + flags |= FOLL_WRITE; ret = -EFAULT; if (atomic_inc_not_zero(&mm->mm_users)) { @@ -517,7 +521,7 @@ __i915_gem_userptr_get_pages_worker(struct work_struct *_work) (work->task, mm, obj->userptr.ptr + pinned * PAGE_SIZE, npages - pinned, - !obj->userptr.read_only, 0, + flags, pvec + pinned, NULL); if (ret < 0) break; |