summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/intel_dpll_mgr.c
diff options
context:
space:
mode:
authorDongwon Kim2016-04-15 00:37:43 +0200
committerImre Deak2016-04-15 15:10:59 +0200
commitda6110bcbc0837eddf6292a0f8cb72f00507fde8 (patch)
treee386b95fb81306771351ae9b438d26f03236315f /drivers/gpu/drm/i915/intel_dpll_mgr.c
parentdrm/i915/bxt: Enable runtime PM (diff)
downloadkernel-qcow2-linux-da6110bcbc0837eddf6292a0f8cb72f00507fde8.tar.gz
kernel-qcow2-linux-da6110bcbc0837eddf6292a0f8cb72f00507fde8.tar.xz
kernel-qcow2-linux-da6110bcbc0837eddf6292a0f8cb72f00507fde8.zip
drm/i915/bxt: PORT_PLL_REF_SEL bit should be set for all BXT variations
This patch is to correct one thing in this commit: commit 25a56705332add0363e47b3a0eca001d6fbd5bec Author: Dongwon Kim <dongwon.kim@intel.com> Date: Wed Mar 16 18:06:13 2016 -0700 drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit This reversed bit polarity is actually common for all BXT and APL SoCs. Therefore, revision checking in the original commit should be removed to make the bit set regardless of revision ID of GFX block. Signed-off-by: Dongwon Kim <dongwon.kim@intel.com> Reviewed-by: Imre Deak <imre.deak@intel.com> Signed-off-by: Imre Deak <imre.deak@intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/1460673463-14453-1-git-send-email-dongwon.kim@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/intel_dpll_mgr.c')
-rw-r--r--drivers/gpu/drm/i915/intel_dpll_mgr.c12
1 files changed, 2 insertions, 10 deletions
diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
index 763132d1b63f..639bf0209c15 100644
--- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
@@ -1295,17 +1295,9 @@ static void bxt_ddi_pll_enable(struct drm_i915_private *dev_priv,
uint32_t temp;
enum port port = (enum port)pll->id; /* 1:1 port->PLL mapping */
- temp = I915_READ(BXT_PORT_PLL_ENABLE(port));
- /*
- * Definition of each bit polarity has been changed
- * after A1 stepping
- */
- if (IS_BXT_REVID(dev_priv, 0, BXT_REVID_A1))
- temp &= ~PORT_PLL_REF_SEL;
- else
- temp |= PORT_PLL_REF_SEL;
-
/* Non-SSC reference */
+ temp = I915_READ(BXT_PORT_PLL_ENABLE(port));
+ temp |= PORT_PLL_REF_SEL;
I915_WRITE(BXT_PORT_PLL_ENABLE(port), temp);
/* Disable 10 bit clock */