diff options
| author | Chris Wilson | 2018-04-30 15:15:03 +0200 |
|---|---|---|
| committer | Chris Wilson | 2018-04-30 17:01:20 +0200 |
| commit | 643b450a594e9cb57fbd2534d1571d244faddd01 (patch) | |
| tree | 161ad01d63b4126d339ac70f10149e9c07638b3e /drivers/gpu/drm/i915/intel_ringbuffer.c | |
| parent | drm/i915: Retire requests along rings (diff) | |
| download | kernel-qcow2-linux-643b450a594e9cb57fbd2534d1571d244faddd01.tar.gz kernel-qcow2-linux-643b450a594e9cb57fbd2534d1571d244faddd01.tar.xz kernel-qcow2-linux-643b450a594e9cb57fbd2534d1571d244faddd01.zip | |
drm/i915: Only track live rings for retiring
We don't need to track every ring for its lifetime as they are managed
by the contexts/engines. What we do want to track are the live rings so
that we can sporadically clean up requests if userspace falls behind. We
can simply restrict the gt->rings list to being only gt->live_rings.
v2: s/live/active/ for consistency with gt.active_requests
Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180430131503.5375-4-chris@chris-wilson.co.uk
Diffstat (limited to 'drivers/gpu/drm/i915/intel_ringbuffer.c')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_ringbuffer.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index ae8958007df5..007449cfa22b 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c @@ -1150,8 +1150,6 @@ intel_engine_create_ring(struct intel_engine_cs *engine, int size) } ring->vma = vma; - list_add(&ring->link, &engine->i915->gt.rings); - return ring; } @@ -1163,8 +1161,6 @@ intel_ring_free(struct intel_ring *ring) i915_vma_close(ring->vma); __i915_gem_object_release_unless_active(obj); - list_del(&ring->link); - kfree(ring); } |