diff options
| author | Chris Wilson | 2017-11-14 23:33:46 +0100 |
|---|---|---|
| committer | Chris Wilson | 2017-11-15 00:50:49 +0100 |
| commit | 6e1281412ab9e6772d8f6c26e592181fcdd2ae0c (patch) | |
| tree | 102892ea5986e3bcfa3a106191805ce3257b8a58 /drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | |
| parent | drm/i915: Resume GuC before using GEM (diff) | |
| download | kernel-qcow2-linux-6e1281412ab9e6772d8f6c26e592181fcdd2ae0c.tar.gz kernel-qcow2-linux-6e1281412ab9e6772d8f6c26e592181fcdd2ae0c.tar.xz kernel-qcow2-linux-6e1281412ab9e6772d8f6c26e592181fcdd2ae0c.zip | |
drm/i915/selftests: Always initialise err
smatch does not track initialised values as well as gcc, and this
triggers many warnings by smatch not presented by gcc. Silence smatch by
initialising the error values to -ENODEV, which we use to denote
internal errors. (If we see a selftest fail with a silent -ENODEV, we
know smatch was right!)
v2: smatch was right about igt_create_vma(), it may unlikely fail on the
first object allocation which we want to be loud about.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20171114223346.25958-1-chris@chris-wilson.co.uk
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Diffstat (limited to 'drivers/gpu/drm/i915/selftests/i915_gem_gtt.c')
| -rw-r--r-- | drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c index 581296860539..d9560d8a6cc8 100644 --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c @@ -699,7 +699,7 @@ static int drunk_hole(struct drm_i915_private *i915, unsigned int *order, count, n; struct i915_vma *vma; u64 hole_size; - int err; + int err = -ENODEV; hole_size = (hole_end - hole_start) >> size; if (hole_size > KMALLOC_MAX_SIZE / sizeof(u32)) @@ -958,7 +958,7 @@ static int exercise_ggtt(struct drm_i915_private *i915, u64 hole_start, hole_end, last = 0; struct drm_mm_node *node; IGT_TIMEOUT(end_time); - int err; + int err = -ENODEV; mutex_lock(&i915->drm.struct_mutex); restart: @@ -1164,7 +1164,7 @@ static int igt_gtt_reserve(void *arg) struct drm_i915_gem_object *obj, *on; LIST_HEAD(objects); u64 total; - int err; + int err = -ENODEV; /* i915_gem_gtt_reserve() tries to reserve the precise range * for the node, and evicts if it has to. So our test checks that @@ -1355,7 +1355,7 @@ static int igt_gtt_insert(void *arg) }, *ii; LIST_HEAD(objects); u64 total; - int err; + int err = -ENODEV; /* i915_gem_gtt_insert() tries to allocate some free space in the GTT * to the node, evicting if required. |