diff options
| author | Adrian Bunk | 2006-03-25 12:08:06 +0100 |
|---|---|---|
| committer | Linus Torvalds | 2006-03-25 17:22:59 +0100 |
| commit | 1f4d4a80fbcb1e09cfb95660bcd2b677ea6d04c1 (patch) | |
| tree | 713ba892d072d36eaf13f28096050fae794a1edb /drivers/isdn/i4l/isdn_tty.c | |
| parent | [PATCH] radix-tree documentation cleanups (diff) | |
| download | kernel-qcow2-linux-1f4d4a80fbcb1e09cfb95660bcd2b677ea6d04c1.tar.gz kernel-qcow2-linux-1f4d4a80fbcb1e09cfb95660bcd2b677ea6d04c1.tar.xz kernel-qcow2-linux-1f4d4a80fbcb1e09cfb95660bcd2b677ea6d04c1.zip | |
[PATCH] i4l/isdn_tty.c: fix a check-after-use
Fix a check-after-use spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Cc: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/isdn/i4l/isdn_tty.c')
| -rw-r--r-- | drivers/isdn/i4l/isdn_tty.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/isdn/i4l/isdn_tty.c b/drivers/isdn/i4l/isdn_tty.c index aeaa1db74bd8..3585fb1f3344 100644 --- a/drivers/isdn/i4l/isdn_tty.c +++ b/drivers/isdn/i4l/isdn_tty.c @@ -2345,12 +2345,15 @@ isdn_tty_at_cout(char *msg, modem_info * info) u_long flags; struct sk_buff *skb = NULL; char *sp = NULL; - int l = strlen(msg); + int l; if (!msg) { printk(KERN_WARNING "isdn_tty: Null-Message in isdn_tty_at_cout\n"); return; } + + l = strlen(msg); + spin_lock_irqsave(&info->readlock, flags); tty = info->tty; if ((info->flags & ISDN_ASYNC_CLOSING) || (!tty)) { |