diff options
| author | Linus Walleij | 2015-12-22 15:47:39 +0100 |
|---|---|---|
| committer | Lee Jones | 2016-01-14 09:43:26 +0100 |
| commit | f7d623669648d2a8d7e81671294c26e480ddcc79 (patch) | |
| tree | bb669a3cc7b2db884e6486a45a82ee6ddadf7bb6 /drivers/mfd/htc-egpio.c | |
| parent | mfd: tc6393xb: Be sure to clamp return value (diff) | |
| download | kernel-qcow2-linux-f7d623669648d2a8d7e81671294c26e480ddcc79.tar.gz kernel-qcow2-linux-f7d623669648d2a8d7e81671294c26e480ddcc79.tar.xz kernel-qcow2-linux-f7d623669648d2a8d7e81671294c26e480ddcc79.zip | |
mfd: htc-egpio: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Cc: Philipp Zabel <philipp.zabel@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd/htc-egpio.c')
| -rw-r--r-- | drivers/mfd/htc-egpio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/htc-egpio.c b/drivers/mfd/htc-egpio.c index 6ccaf90d98fd..e4f4a31b76d9 100644 --- a/drivers/mfd/htc-egpio.c +++ b/drivers/mfd/htc-egpio.c @@ -163,7 +163,7 @@ static int egpio_get(struct gpio_chip *chip, unsigned offset) value = egpio_readw(ei, reg); pr_debug("readw(%p + %x) = %x\n", ei->base_addr, reg << ei->bus_shift, value); - return value & bit; + return !!(value & bit); } static int egpio_direction_input(struct gpio_chip *chip, unsigned offset) |