summaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/ath/ath5k/base.c
diff options
context:
space:
mode:
authorPavel Roskin2009-08-27 04:30:00 +0200
committerJohn W. Linville2009-08-28 20:40:54 +0200
commit3b3ee43da43aca1cbf4c3651379b2b1492e49dd6 (patch)
tree2b2ffa22c55e817f168dbf1e179ead2050fca7ec /drivers/net/wireless/ath/ath5k/base.c
parentath5k: clarify srev comparison for CCMP check (diff)
downloadkernel-qcow2-linux-3b3ee43da43aca1cbf4c3651379b2b1492e49dd6.tar.gz
kernel-qcow2-linux-3b3ee43da43aca1cbf4c3651379b2b1492e49dd6.tar.xz
kernel-qcow2-linux-3b3ee43da43aca1cbf4c3651379b2b1492e49dd6.zip
ath5k: fix uninitialized value use in ath5k_eeprom_read_turbo_modes()
The `val' variable in ath5k_eeprom_read_turbo_modes() is used uninitialized. gcc 4.4.1 with -fno-inline-functions-called-once reports it: eeprom.c: In function 'ath5k_eeprom_read_turbo_modes': eeprom.c:441: warning: 'val' may be used uninitialized in this function Comparing the code to the Atheros HAL, it's clear that the split between ath5k_eeprom_read_modes() and ath5k_eeprom_read_turbo_modes() was incorrect. The Atheros HAL reads both turbo and non-turbo data from EEPROM in one function. Some turbo mode parameters are derived from the same EEPROM values as non-turbo parameters, just from different bits. Merge ath5k_eeprom_read_turbo_modes() into ath5k_eeprom_read_modes() to fix the warning. The actual values and offsets have been cross-checked against Atheros HAL. Signed-off-by: Pavel Roskin <proski@gnu.org> Acked-by: Bob Copeland <me@bobcopeland.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/ath/ath5k/base.c')
0 files changed, 0 insertions, 0 deletions