diff options
| author | Jiri Slaby | 2008-02-15 21:58:52 +0100 |
|---|---|---|
| committer | John W. Linville | 2008-02-21 02:11:48 +0100 |
| commit | b988763857426020e50a19434c8434a1e08e70eb (patch) | |
| tree | 102f17ff0319d9115eafd91286a727659335bebe /drivers/net/wireless/ath5k/base.c | |
| parent | WDEV: ath5k, fix lock imbalance (diff) | |
| download | kernel-qcow2-linux-b988763857426020e50a19434c8434a1e08e70eb.tar.gz kernel-qcow2-linux-b988763857426020e50a19434c8434a1e08e70eb.tar.xz kernel-qcow2-linux-b988763857426020e50a19434c8434a1e08e70eb.zip | |
WDEV, ath5k, don't return int from bool function
sparse sees int -> bool cast as an error:
hw.c:3754:10: warning: cast truncates bits from constant value (ffffffea becomes 0)
Fix it by converting the rettype to int and check appropriately.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Nick Kossifidis <mickflemm@gmail.com>
Cc: Luis R. Rodriguez <mcgrof@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/ath5k/base.c')
| -rw-r--r-- | drivers/net/wireless/ath5k/base.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c index 062d004076a2..81b45b3e0f02 100644 --- a/drivers/net/wireless/ath5k/base.c +++ b/drivers/net/wireless/ath5k/base.c @@ -668,7 +668,10 @@ ath5k_attach(struct pci_dev *pdev, struct ieee80211_hw *hw) * return false w/o doing anything. MAC's that do * support it will return true w/o doing anything. */ - if (ah->ah_setup_xtx_desc(ah, NULL, 0, 0, 0, 0, 0, 0)) + ret = ah->ah_setup_xtx_desc(ah, NULL, 0, 0, 0, 0, 0, 0); + if (ret < 0) + goto err; + if (ret > 0) __set_bit(ATH_STAT_MRRETRY, sc->status); /* |