diff options
| author | Dan Williams | 2015-09-15 08:42:20 +0200 |
|---|---|---|
| committer | Dan Williams | 2015-10-09 23:00:33 +0200 |
| commit | b36f47617f6ce7c5e8e7c264b9d9ea0654d9f20a (patch) | |
| tree | d08894bd10818244ad58444151f201eacc6fa5a7 /drivers/nvdimm/pmem.c | |
| parent | devm_memunmap: use devres_release() (diff) | |
| download | kernel-qcow2-linux-b36f47617f6ce7c5e8e7c264b9d9ea0654d9f20a.tar.gz kernel-qcow2-linux-b36f47617f6ce7c5e8e7c264b9d9ea0654d9f20a.tar.xz kernel-qcow2-linux-b36f47617f6ce7c5e8e7c264b9d9ea0654d9f20a.zip | |
devm_memremap: convert to return ERR_PTR
Make devm_memremap consistent with the error return scheme of
devm_memremap_pages to remove special casing in the pmem driver.
Cc: Christoph Hellwig <hch@lst.de>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/nvdimm/pmem.c')
| -rw-r--r-- | drivers/nvdimm/pmem.c | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 0680affae04a..9805d311b1d1 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -150,19 +150,15 @@ static struct pmem_device *pmem_alloc(struct device *dev, return ERR_PTR(-EBUSY); } - if (pmem_should_map_pages(dev)) { - void *addr = devm_memremap_pages(dev, res); - - if (IS_ERR(addr)) - return addr; - pmem->virt_addr = (void __pmem *) addr; - } else { + if (pmem_should_map_pages(dev)) + pmem->virt_addr = (void __pmem *) devm_memremap_pages(dev, res); + else pmem->virt_addr = (void __pmem *) devm_memremap(dev, pmem->phys_addr, pmem->size, ARCH_MEMREMAP_PMEM); - if (!pmem->virt_addr) - return ERR_PTR(-ENXIO); - } + + if (IS_ERR(pmem->virt_addr)) + return (void __force *) pmem->virt_addr; return pmem; } |