summaryrefslogtreecommitdiffstats
path: root/drivers/staging
diff options
context:
space:
mode:
authorTomas Winkler2011-11-09 12:26:36 +0100
committerMauro Carvalho Chehab2011-11-24 22:14:15 +0100
commit7dfdae8e32a26ef3b3aa8d114d2fed93d7680169 (patch)
treea9c394a9edec281fffe764cff15871abda276a8d /drivers/staging
parent[media] easycap: streamline the code (diff)
downloadkernel-qcow2-linux-7dfdae8e32a26ef3b3aa8d114d2fed93d7680169.tar.gz
kernel-qcow2-linux-7dfdae8e32a26ef3b3aa8d114d2fed93d7680169.tar.xz
kernel-qcow2-linux-7dfdae8e32a26ef3b3aa8d114d2fed93d7680169.zip
[media] easycap: drop initializations to 0 in the probe functions
peasycap was allocated using kzalloc so drop all to zero initializations Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/staging')
-rw-r--r--drivers/staging/media/easycap/easycap_main.c29
1 files changed, 3 insertions, 26 deletions
diff --git a/drivers/staging/media/easycap/easycap_main.c b/drivers/staging/media/easycap/easycap_main.c
index 044c762f337a..8da1682aa64e 100644
--- a/drivers/staging/media/easycap/easycap_main.c
+++ b/drivers/staging/media/easycap/easycap_main.c
@@ -3005,11 +3005,6 @@ static int easycap_usb_probe(struct usb_interface *intf,
mutex_unlock(&mutex_dongle);
peasycap->allocation_video_struct = sizeof(struct easycap);
- peasycap->allocation_video_page = 0;
- peasycap->allocation_video_urb = 0;
- peasycap->allocation_audio_struct = 0;
- peasycap->allocation_audio_page = 0;
- peasycap->allocation_audio_urb = 0;
/*---------------------------------------------------------------------------*/
/*
@@ -3019,7 +3014,6 @@ static int easycap_usb_probe(struct usb_interface *intf,
peasycap->pusb_device = usbdev;
peasycap->pusb_interface = intf;
- peasycap->ilk = 0;
peasycap->microphone = false;
peasycap->video_interface = -1;
@@ -3038,11 +3032,6 @@ static int easycap_usb_probe(struct usb_interface *intf,
peasycap->frame_buffer_many = FRAME_BUFFER_MANY;
- for (k = 0; k < INPUT_MANY; k++)
- peasycap->lost[k] = 0;
- peasycap->skip = 0;
- peasycap->skipped = 0;
- peasycap->offerfields = 0;
/*---------------------------------------------------------------------------*/
/*
* DYNAMICALLY FILL IN THE AVAILABLE FORMATS ...
@@ -3054,22 +3043,10 @@ static int easycap_usb_probe(struct usb_interface *intf,
return -EFAULT;
}
JOM(4, "%i formats available\n", rc);
-/*---------------------------------------------------------------------------*/
-/*
- * ... AND POPULATE easycap.inputset[]
-*/
-/*---------------------------------------------------------------------------*/
- /* FIXME: maybe we just use memset 0 */
+
+ /* ... AND POPULATE easycap.inputset[] */
+
inputset = peasycap->inputset;
- for (k = 0; k < INPUT_MANY; k++) {
- inputset[k].input_ok = 0;
- inputset[k].standard_offset_ok = 0;
- inputset[k].format_offset_ok = 0;
- inputset[k].brightness_ok = 0;
- inputset[k].contrast_ok = 0;
- inputset[k].saturation_ok = 0;
- inputset[k].hue_ok = 0;
- }
fmtidx = peasycap->ntsc ? NTSC_M : PAL_BGHIN;
m = 0;