diff options
| author | Chris Boot | 2012-12-11 22:58:47 +0100 |
|---|---|---|
| committer | Nicholas Bellinger | 2012-12-13 06:16:47 +0100 |
| commit | 37419d674ca99739dbee5ada28b50aacc29c94e1 (patch) | |
| tree | 727a2b2faf812f9d8d3c36398a88f213f3248ed4 /drivers/target/sbp | |
| parent | iscsi-target: use kstrdup() for iscsi_param (diff) | |
| download | kernel-qcow2-linux-37419d674ca99739dbee5ada28b50aacc29c94e1.tar.gz kernel-qcow2-linux-37419d674ca99739dbee5ada28b50aacc29c94e1.tar.xz kernel-qcow2-linux-37419d674ca99739dbee5ada28b50aacc29c94e1.zip | |
sbp-target: use simple assignment in tgt_agent_rw_agent_state()
There is no need to memcpy() a 32-bit integer. The data pointer is
guaranteed to be quadlet aligned by the FireWire stack so we can replace
the memcpy() with an assignment.
Thanks to Stefan Richter.
Signed-off-by: Chris Boot <bootc@bootc.net>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Andy Grover <agrover@redhat.com>
Cc: Clemens Ladisch <clemens@ladisch.de>
Cc: Nicholas A. Bellinger <nab@linux-iscsi.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/sbp')
| -rw-r--r-- | drivers/target/sbp/sbp_target.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c index 0d6d7c1f025e..f0a2a1d982a2 100644 --- a/drivers/target/sbp/sbp_target.c +++ b/drivers/target/sbp/sbp_target.c @@ -704,16 +704,17 @@ static void session_maintenance_work(struct work_struct *work) static int tgt_agent_rw_agent_state(struct fw_card *card, int tcode, void *data, struct sbp_target_agent *agent) { - __be32 state; + int state; switch (tcode) { case TCODE_READ_QUADLET_REQUEST: pr_debug("tgt_agent AGENT_STATE READ\n"); spin_lock_bh(&agent->lock); - state = cpu_to_be32(agent->state); + state = agent->state; spin_unlock_bh(&agent->lock); - memcpy(data, &state, sizeof(state)); + + *(__be32 *)data = cpu_to_be32(state); return RCODE_COMPLETE; |