diff options
| author | Nicholas Bellinger | 2012-03-10 23:36:21 +0100 |
|---|---|---|
| committer | Nicholas Bellinger | 2012-03-10 23:42:19 +0100 |
| commit | 337c060701fb3d27d9945bf7af7ba194ae2153a8 (patch) | |
| tree | 7b2d50a7cc4b291a876e95c60388cf57a52d912a /drivers/target/target_core_transport.c | |
| parent | target: Add se_node_acl->acl_kref for ->acl_free_comp usage (diff) | |
| download | kernel-qcow2-linux-337c060701fb3d27d9945bf7af7ba194ae2153a8.tar.gz kernel-qcow2-linux-337c060701fb3d27d9945bf7af7ba194ae2153a8.tar.xz kernel-qcow2-linux-337c060701fb3d27d9945bf7af7ba194ae2153a8.zip | |
target: Convert se_node_acl->acl_group removal to use ->acl_kref
This patch converts core_tpg_del_initiator_node_acl() shutdown from configfs
context to use se_node_acl->acl_kref and ->acl_free_comp in order to wait for
outstanding fabric callbacks to complete via transport_deregister_session()
callbacks before waking ->acl_free_comp from the last ->acl_kref put.
It also changes core_tpg_del_initiator_node_acl() to setup a local sess_list
with target_get_session() + acl->acl_stop = 1 for active sessions that will
be shutdown, and changes transport_deregister_session_configfs() to check
for ->acl_stop usage.
Cc: Roland Dreier <roland@purestorage.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Joern Engel <joern@logfs.org>
Cc: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/target_core_transport.c')
| -rw-r--r-- | drivers/target/target_core_transport.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index efefbec286fc..ba8eb8373032 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -360,7 +360,8 @@ void transport_deregister_session_configfs(struct se_session *se_sess) se_nacl = se_sess->se_node_acl; if (se_nacl) { spin_lock_irqsave(&se_nacl->nacl_sess_lock, flags); - list_del(&se_sess->sess_acl_list); + if (se_nacl->acl_stop == 0) + list_del(&se_sess->sess_acl_list); /* * If the session list is empty, then clear the pointer. * Otherwise, set the struct se_session pointer from the tail |