diff options
| author | Nicholas Bellinger | 2011-09-29 23:22:13 +0200 |
|---|---|---|
| committer | Nicholas Bellinger | 2011-10-24 05:20:12 +0200 |
| commit | c252f003470a99d319db4ebd12f4a9e4710a65db (patch) | |
| tree | 4874bcd5c62a8c45750c8e28ace14fa8c717e6ed /drivers/target | |
| parent | target: Fix transport_cmd_finish_abort queue removal bug (diff) | |
| download | kernel-qcow2-linux-c252f003470a99d319db4ebd12f4a9e4710a65db.tar.gz kernel-qcow2-linux-c252f003470a99d319db4ebd12f4a9e4710a65db.tar.xz kernel-qcow2-linux-c252f003470a99d319db4ebd12f4a9e4710a65db.zip | |
target: Prevent transport_send_task_abort when CHECK_CONDITION status
This patch fixes a bug where transport_send_task_abort() could be called
during LUN_RESET to return SAM_STAT_TASK_ABORTED + tfo->queue_status(), when
SCF_SENT_CHECK_CONDITION -> tfo->queue_status() has already been sent from
within another context via transport_send_check_condition_and_sense().
Cc: stable@kernel.org
Signed-off-by: Nicholas Bellinger <nab@risingtidesystems.com>
Diffstat (limited to 'drivers/target')
| -rw-r--r-- | drivers/target/target_core_transport.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 009547b35574..af1e0a5f9bc6 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -4919,6 +4919,15 @@ EXPORT_SYMBOL(transport_check_aborted_status); void transport_send_task_abort(struct se_cmd *cmd) { + unsigned long flags; + + spin_lock_irqsave(&cmd->t_state_lock, flags); + if (cmd->se_cmd_flags & SCF_SENT_CHECK_CONDITION) { + spin_unlock_irqrestore(&cmd->t_state_lock, flags); + return; + } + spin_unlock_irqrestore(&cmd->t_state_lock, flags); + /* * If there are still expected incoming fabric WRITEs, we wait * until until they have completed before sending a TASK_ABORTED |