summaryrefslogtreecommitdiffstats
path: root/drivers/vhost/net.c
diff options
context:
space:
mode:
authorJason Wang2019-06-17 11:20:54 +0200
committerGreg Kroah-Hartman2019-07-26 09:14:08 +0200
commit0e2af9b06c00a30bc396cf455f50320a7c5b71da (patch)
tree31a9be048442ee5e919197f7ba0437f852e5f97f /drivers/vhost/net.c
parentperf evsel: Make perf_evsel__name() accept a NULL argument (diff)
downloadkernel-qcow2-linux-0e2af9b06c00a30bc396cf455f50320a7c5b71da.tar.gz
kernel-qcow2-linux-0e2af9b06c00a30bc396cf455f50320a7c5b71da.tar.xz
kernel-qcow2-linux-0e2af9b06c00a30bc396cf455f50320a7c5b71da.zip
vhost_net: disable zerocopy by default
[ Upstream commit 098eadce3c622c07b328d0a43dda379b38cf7c5e ] Vhost_net was known to suffer from HOL[1] issues which is not easy to fix. Several downstream disable the feature by default. What's more, the datapath was split and datacopy path got the support of batching and XDP support recently which makes it faster than zerocopy part for small packets transmission. It looks to me that disable zerocopy by default is more appropriate. It cold be enabled by default again in the future if we fix the above issues. [1] https://patchwork.kernel.org/patch/3787671/ Signed-off-by: Jason Wang <jasowang@redhat.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/vhost/net.c')
-rw-r--r--drivers/vhost/net.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index 39155d7cc894..ae704658b528 100644
--- a/drivers/vhost/net.c
+++ b/drivers/vhost/net.c
@@ -36,7 +36,7 @@
#include "vhost.h"
-static int experimental_zcopytx = 1;
+static int experimental_zcopytx = 0;
module_param(experimental_zcopytx, int, 0444);
MODULE_PARM_DESC(experimental_zcopytx, "Enable Zero Copy TX;"
" 1 -Enable; 0 - Disable");