diff options
| author | Chen Gang | 2013-08-20 04:33:56 +0200 |
|---|---|---|
| committer | Tomi Valkeinen | 2013-08-30 10:41:24 +0200 |
| commit | 9bb40585c9d934db3585e1f422e2ffb1dd5e9631 (patch) | |
| tree | ae644be218e1fd1ddeab3065ccb6bdef35d7c198 /drivers/video/fbcmap.c | |
| parent | video: mxsfb: simplify use of devm_ioremap_resource (diff) | |
| download | kernel-qcow2-linux-9bb40585c9d934db3585e1f422e2ffb1dd5e9631.tar.gz kernel-qcow2-linux-9bb40585c9d934db3585e1f422e2ffb1dd5e9631.tar.xz kernel-qcow2-linux-9bb40585c9d934db3585e1f422e2ffb1dd5e9631.zip | |
drivers: video: fbcmap: remove the redundency and incorrect checkings
fb_set_cmap() already checks the parameters, so need remove the
redundancy checking.
This redundancy checking is also incorrect, the related warning:
drivers/video/fbcmap.c:288:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers/video/fbcmap.c')
| -rw-r--r-- | drivers/video/fbcmap.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/video/fbcmap.c b/drivers/video/fbcmap.c index 5c3960da755a..f89245b8ba8e 100644 --- a/drivers/video/fbcmap.c +++ b/drivers/video/fbcmap.c @@ -285,13 +285,8 @@ int fb_set_user_cmap(struct fb_cmap_user *cmap, struct fb_info *info) rc = -ENODEV; goto out; } - if (cmap->start < 0 || (!info->fbops->fb_setcolreg && - !info->fbops->fb_setcmap)) { - rc = -EINVAL; - goto out1; - } + rc = fb_set_cmap(&umap, info); -out1: unlock_fb_info(info); out: fb_dealloc_cmap(&umap); |