diff options
| author | Jia-Ju Bai | 2018-04-09 17:04:12 +0200 |
|---|---|---|
| committer | Boris Ostrovsky | 2018-04-16 16:20:21 +0200 |
| commit | 9eb5f15b47b69847bfceb94350bd68fbdbf829e3 (patch) | |
| tree | 041219820c19cb917a6e0fdc5aef4ecdd3001745 /drivers/xen/xen-pciback/conf_space_quirks.c | |
| parent | xen: xen-pciback: Replace GFP_ATOMIC with GFP_KERNEL in pcistub_init_device (diff) | |
| download | kernel-qcow2-linux-9eb5f15b47b69847bfceb94350bd68fbdbf829e3.tar.gz kernel-qcow2-linux-9eb5f15b47b69847bfceb94350bd68fbdbf829e3.tar.xz kernel-qcow2-linux-9eb5f15b47b69847bfceb94350bd68fbdbf829e3.zip | |
xen: xen-pciback: Replace GFP_ATOMIC with GFP_KERNEL in pcistub_device_alloc
pcistub_device_alloc() is never called in atomic context.
The call chain ending up at pcistub_device_alloc() is:
[1] pcistub_device_alloc() <- pcistub_seize() <- pcistub_probe()
pcistub_probe() is only set as ".probe" in struct pci_driver.
This function is not called in atomic context.
Despite never getting called from atomic context,
pcistub_device_alloc() calls kzalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Diffstat (limited to 'drivers/xen/xen-pciback/conf_space_quirks.c')
0 files changed, 0 insertions, 0 deletions