diff options
| author | Alan Stern | 2005-05-06 21:41:08 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2005-06-21 00:15:29 +0200 |
| commit | f409661877a25d11c2495bcd879807f17c286684 (patch) | |
| tree | ce14b7c16191af662d087c9be4a3fcbe642a63af /drivers | |
| parent | [PATCH] driver core: Fix races in driver_detach() (diff) | |
| download | kernel-qcow2-linux-f409661877a25d11c2495bcd879807f17c286684.tar.gz kernel-qcow2-linux-f409661877a25d11c2495bcd879807f17c286684.tar.xz kernel-qcow2-linux-f409661877a25d11c2495bcd879807f17c286684.zip | |
[PATCH] usbcore: Don't call device_release_driver recursively
This patch fixes usb_driver_release_interface() to make it avoid calling
device_release_driver() recursively, i.e., when invoked from within the
disconnect routine for the same device. The patch applies to your
"driver" tree.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/usb/core/usb.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c index 66678763c24d..a3c42203213a 100644 --- a/drivers/usb/core/usb.c +++ b/drivers/usb/core/usb.c @@ -322,9 +322,15 @@ void usb_driver_release_interface(struct usb_driver *driver, if (!dev->driver || dev->driver != &driver->driver) return; - /* don't disconnect from disconnect(), or before dev_add() */ - if (!klist_node_attached(&dev->knode_driver) && !klist_node_attached(&dev->knode_bus)) + /* don't release from within disconnect() */ + if (iface->condition != USB_INTERFACE_BOUND) + return; + + /* release only after device_add() */ + if (klist_node_attached(&dev->knode_bus)) { + iface->condition = USB_INTERFACE_UNBINDING; device_release_driver(dev); + } dev->driver = NULL; usb_set_intfdata(iface, NULL); |