summaryrefslogtreecommitdiffstats
path: root/fs/f2fs/checkpoint.c
diff options
context:
space:
mode:
authorGu Zheng2013-11-26 09:44:16 +0100
committerJaegeuk Kim2013-12-23 02:18:04 +0100
commit36795567942a033ef9e22d8eba86396ffb9aa80c (patch)
treec02b4f392993b4b7c9db64862d16db9bbed2e304 /fs/f2fs/checkpoint.c
parentf2fs: remove unnecessary return value (diff)
downloadkernel-qcow2-linux-36795567942a033ef9e22d8eba86396ffb9aa80c.tar.gz
kernel-qcow2-linux-36795567942a033ef9e22d8eba86396ffb9aa80c.tar.xz
kernel-qcow2-linux-36795567942a033ef9e22d8eba86396ffb9aa80c.zip
f2fs: fix a potential out of range issue
Fix a potential out of range issue introduced by commit: 22fb72225a f2fs: simplify write_orphan_inodes for better readable Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com> Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Diffstat (limited to 'fs/f2fs/checkpoint.c')
-rw-r--r--fs/f2fs/checkpoint.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index 7fe69ff2bfe7..3e62987e333a 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -323,9 +323,9 @@ static void write_orphan_inodes(struct f2fs_sb_info *sbi, block_t start_blk)
memset(orphan_blk, 0, sizeof(*orphan_blk));
}
- orphan_blk->ino[nentries] = cpu_to_le32(orphan->ino);
+ orphan_blk->ino[nentries++] = cpu_to_le32(orphan->ino);
- if (nentries++ == F2FS_ORPHANS_PER_BLOCK) {
+ if (nentries == F2FS_ORPHANS_PER_BLOCK) {
/*
* an orphan block is full of 1020 entries,
* then we need to flush current orphan blocks