diff options
| author | Wendy Cheng | 2007-06-27 23:07:53 +0200 |
|---|---|---|
| committer | Steven Whitehouse | 2007-07-09 09:24:11 +0200 |
| commit | 35dcc52e3a916184b145fd840250244b81004200 (patch) | |
| tree | f3ab5a4094a676967e668fb407c0296a1150264a /fs/gfs2/rgrp.c | |
| parent | [GFS2] Obtaining no_formal_ino from directory entry (diff) | |
| download | kernel-qcow2-linux-35dcc52e3a916184b145fd840250244b81004200.tar.gz kernel-qcow2-linux-35dcc52e3a916184b145fd840250244b81004200.tar.xz kernel-qcow2-linux-35dcc52e3a916184b145fd840250244b81004200.zip | |
[GFS2] Remove i_mode passing from NFS File Handle
GFS2 has been passing i_mode within NFS File Handle. Other than the
wrong assumption that there is always room for this extra 16 bit value,
the current gfs2_get_dentry doesn't really need the i_mode to work
correctly. Note that GFS2 NFS code does go thru the same lookup code
path as direct file access route (where the mode is obtained from name
lookup) but gfs2_get_dentry() is coded for different purpose. It is not
used during lookup time. It is part of the file access procedure call.
When the call is invoked, if on-disk inode is not in-memory, it has to
be read-in. This makes i_mode passing a useless overhead.
Signed-off-by: S. Wendy Cheng <wcheng@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2/rgrp.c')
| -rw-r--r-- | fs/gfs2/rgrp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 7fb74484af63..e4e040625153 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -872,7 +872,7 @@ static struct inode *try_rgrp_unlink(struct gfs2_rgrpd *rgd, u64 *last_unlinked) continue; *last_unlinked = no_addr; inode = gfs2_inode_lookup(rgd->rd_sbd->sd_vfs, DT_UNKNOWN, - no_addr, 0); + no_addr, -1); if (!IS_ERR(inode)) return inode; } |