diff options
| author | Trond Myklebust | 2007-03-16 22:38:28 +0100 |
|---|---|---|
| committer | Linus Torvalds | 2007-03-17 03:25:06 +0100 |
| commit | 634707388baa440d9c9d082cfc4c950500c8952b (patch) | |
| tree | 0d3075c34a69a2d4c5c3d5682fd6a0d26bff28e9 /fs/nfs | |
| parent | [PATCH] nfs: fix congestion control (diff) | |
| download | kernel-qcow2-linux-634707388baa440d9c9d082cfc4c950500c8952b.tar.gz kernel-qcow2-linux-634707388baa440d9c9d082cfc4c950500c8952b.tar.xz kernel-qcow2-linux-634707388baa440d9c9d082cfc4c950500c8952b.zip | |
[PATCH] nfs: nfs_getattr() can't call nfs_sync_mapping_range() for non-regular files
Looks like we need a check in nfs_getattr() for a regular file. It makes
no sense to call nfs_sync_mapping_range() on anything else. I think that
should fix your problem: it will stop the NFS client from interfering
with dirty pages on that inode's mapping.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Acked-by: Olof Johansson <olof@lixom.net>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/nfs')
| -rw-r--r-- | fs/nfs/inode.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index af53c02f473b..93d046c85f52 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c @@ -429,7 +429,8 @@ int nfs_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat) int err; /* Flush out writes to the server in order to update c/mtime */ - nfs_sync_mapping_range(inode->i_mapping, 0, 0, FLUSH_NOCOMMIT); + if (S_ISREG(inode->i_mode)) + nfs_sync_mapping_range(inode->i_mapping, 0, 0, FLUSH_NOCOMMIT); /* * We may force a getattr if the user cares about atime. |