diff options
| author | Li Zefan | 2009-04-08 09:06:12 +0200 |
|---|---|---|
| committer | Al Viro | 2009-04-21 05:02:50 +0200 |
| commit | 3939fcde24473dc09ce16e922c88df9b3bee45d9 (patch) | |
| tree | fe1525d311cad56f25323a659e6c1811b22c0a8d /fs/xattr.c | |
| parent | autofs4: use memchr() in invalid_string() (diff) | |
| download | kernel-qcow2-linux-3939fcde24473dc09ce16e922c88df9b3bee45d9.tar.gz kernel-qcow2-linux-3939fcde24473dc09ce16e922c88df9b3bee45d9.tar.xz kernel-qcow2-linux-3939fcde24473dc09ce16e922c88df9b3bee45d9.zip | |
xattr: use memdup_user()
Remove open-coded memdup_user()
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/xattr.c')
| -rw-r--r-- | fs/xattr.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/fs/xattr.c b/fs/xattr.c index 197c4fcac032..d51b8f9db921 100644 --- a/fs/xattr.c +++ b/fs/xattr.c @@ -237,13 +237,9 @@ setxattr(struct dentry *d, const char __user *name, const void __user *value, if (size) { if (size > XATTR_SIZE_MAX) return -E2BIG; - kvalue = kmalloc(size, GFP_KERNEL); - if (!kvalue) - return -ENOMEM; - if (copy_from_user(kvalue, value, size)) { - kfree(kvalue); - return -EFAULT; - } + kvalue = memdup_user(value, size); + if (IS_ERR(kvalue)) + return PTR_ERR(kvalue); } error = vfs_setxattr(d, kname, kvalue, size, flags); |