diff options
| author | Steven Whitehouse | 2006-11-22 17:13:21 +0100 |
|---|---|---|
| committer | Steven Whitehouse | 2006-11-30 16:36:33 +0100 |
| commit | 28626e2078571c4b776a17eaa486bbd2b7dfe2cd (patch) | |
| tree | 7baa910604078685266ebc023121a536b0931b88 /fs | |
| parent | [GFS2] Simplify glops functions (diff) | |
| download | kernel-qcow2-linux-28626e2078571c4b776a17eaa486bbd2b7dfe2cd.tar.gz kernel-qcow2-linux-28626e2078571c4b776a17eaa486bbd2b7dfe2cd.tar.xz kernel-qcow2-linux-28626e2078571c4b776a17eaa486bbd2b7dfe2cd.zip | |
[GFS2] Fix glock ordering on inode creation
The lock order here should be parent -> child rather than
numeric order.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/gfs2/inode.c | 31 |
1 files changed, 4 insertions, 27 deletions
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index ce7f83306909..d122074c45e1 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c @@ -870,33 +870,10 @@ struct inode *gfs2_createi(struct gfs2_holder *ghs, const struct qstr *name, if (error) goto fail_gunlock; - if (inum.no_addr < dip->i_num.no_addr) { - gfs2_glock_dq(ghs); - - error = gfs2_glock_nq_num(sdp, inum.no_addr, - &gfs2_inode_glops, LM_ST_EXCLUSIVE, - GL_SKIP, ghs + 1); - if (error) { - return ERR_PTR(error); - } - - gfs2_holder_reinit(LM_ST_EXCLUSIVE, 0, ghs); - error = gfs2_glock_nq(ghs); - if (error) { - gfs2_glock_dq_uninit(ghs + 1); - return ERR_PTR(error); - } - - error = create_ok(dip, name, mode); - if (error) - goto fail_gunlock2; - } else { - error = gfs2_glock_nq_num(sdp, inum.no_addr, - &gfs2_inode_glops, LM_ST_EXCLUSIVE, - GL_SKIP, ghs + 1); - if (error) - goto fail_gunlock; - } + error = gfs2_glock_nq_num(sdp, inum.no_addr, &gfs2_inode_glops, + LM_ST_EXCLUSIVE, GL_SKIP, ghs + 1); + if (error) + goto fail_gunlock; error = make_dinode(dip, ghs[1].gh_gl, mode, &inum, &generation, dev); if (error) |