diff options
| author | Trond Myklebust | 2019-08-03 16:28:18 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2019-08-16 10:12:53 +0200 |
| commit | d1489f0b4de73a06f10d3cc9c7dddc5f89784abb (patch) | |
| tree | 2a50b33640afb0ebd94150391cc4978283076f5d /fs | |
| parent | smb3: send CAP_DFS capability during session setup (diff) | |
| download | kernel-qcow2-linux-d1489f0b4de73a06f10d3cc9c7dddc5f89784abb.tar.gz kernel-qcow2-linux-d1489f0b4de73a06f10d3cc9c7dddc5f89784abb.tar.xz kernel-qcow2-linux-d1489f0b4de73a06f10d3cc9c7dddc5f89784abb.zip | |
NFSv4: Fix an Oops in nfs4_do_setattr
commit 09a54f0ebfe263bc27c90bbd80187b9a93283887 upstream.
If the user specifies an open mode of 3, then we don't have a NFSv4 state
attached to the context, and so we Oops when we try to dereference it.
Reported-by: Olga Kornievskaia <aglo@umich.edu>
Fixes: 29b59f9416937 ("NFSv4: change nfs4_do_setattr to take...")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: stable@vger.kernel.org # v4.10: 991eedb1371dc: NFSv4: Only pass the...
Cc: stable@vger.kernel.org # v4.10+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/nfs/nfs4proc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 904e08bbb289..31ae3bd5d9d2 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -3133,7 +3133,7 @@ static int _nfs4_do_setattr(struct inode *inode, if (nfs4_copy_delegation_stateid(inode, FMODE_WRITE, &arg->stateid, &delegation_cred)) { /* Use that stateid */ - } else if (ctx != NULL) { + } else if (ctx != NULL && ctx->state) { struct nfs_lock_context *l_ctx; if (!nfs4_valid_open_stateid(ctx->state)) return -EBADF; |