summaryrefslogtreecommitdiffstats
path: root/kernel/module.c
diff options
context:
space:
mode:
authorLinus Torvalds2008-08-25 20:10:26 +0200
committerLinus Torvalds2008-08-25 20:10:26 +0200
commitffb4ba76a25ab6c9deeec33e4f58395586ca747c (patch)
tree378ee35adc486466c88c7423dbb0ecc6f027ef45 /kernel/module.c
parentFix oops in acer_wmi driver (acer_wmi_init) (diff)
downloadkernel-qcow2-linux-ffb4ba76a25ab6c9deeec33e4f58395586ca747c.tar.gz
kernel-qcow2-linux-ffb4ba76a25ab6c9deeec33e4f58395586ca747c.tar.xz
kernel-qcow2-linux-ffb4ba76a25ab6c9deeec33e4f58395586ca747c.zip
[module] Don't let gcc inline load_module()
'load_module()' is a complex function that contains all the ELF section logic, and inlining it is utterly insane. But gcc will do it, simply because there is only one call-site. As a result, all the stack space that is allocated for all the work to load the module will still be active when we actually call the module init sequence, and the deep call chain makes stack overflows happen. And stack overflows are really hard to debug, because they not only corrupt random pages below the stack, but also corrupt the thread_info structure that is allocated under the stack. In this case, Alan Brunelle reported some crazy oopses at bootup, after loading the processor module that ends up doing complex ACPI stuff and has quite a deep callchain. This should fix it, and is the sane thing to do regardless. Cc: Alan D. Brunelle <Alan.Brunelle@hp.com> Cc: Arjan van de Ven <arjan@linux.intel.com> Cc: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/module.c')
-rw-r--r--kernel/module.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/module.c b/kernel/module.c
index 08864d257eb0..9db11911e04b 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1799,7 +1799,7 @@ static void *module_alloc_update_bounds(unsigned long size)
/* Allocate and load the module: note that size of section 0 is always
zero, and we rely on this for optional sections. */
-static struct module *load_module(void __user *umod,
+static noinline struct module *load_module(void __user *umod,
unsigned long len,
const char __user *uargs)
{