diff options
| author | Hugh Dickins | 2012-10-09 01:29:07 +0200 |
|---|---|---|
| committer | Linus Torvalds | 2012-10-09 09:22:20 +0200 |
| commit | 6597d783397aebb793fb529474cce5089aa4c67f (patch) | |
| tree | 059d7e4c18c8cec61a71a6c15994867dceb7b93a /mm/compaction.c | |
| parent | mm: fix nonuniform page status when writing new file with small buffer (diff) | |
| download | kernel-qcow2-linux-6597d783397aebb793fb529474cce5089aa4c67f.tar.gz kernel-qcow2-linux-6597d783397aebb793fb529474cce5089aa4c67f.tar.xz kernel-qcow2-linux-6597d783397aebb793fb529474cce5089aa4c67f.zip | |
mm/mmap.c: replace find_vma_prepare() with clearer find_vma_links()
People get confused by find_vma_prepare(), because it doesn't care about
what it returns in its output args, when its callers won't be interested.
Clarify by passing in end-of-range address too, and returning failure if
any existing vma overlaps the new range: instead of returning an ambiguous
vma which most callers then must check. find_vma_links() is a clearer
name.
This does revert 2.6.27's dfe195fb79e88 ("mm: fix uninitialized variables
for find_vma_prepare callers"), but it looks like gcc 4.3.0 was one of
those releases too eager to shout about uninitialized variables: only
copy_vma() warns with 4.5.1 and 4.7.1, which a BUG on error silences.
[hughd@google.com: fix warning, remove BUG()]
Signed-off-by: Hugh Dickins <hughd@google.com>
Cc: Benny Halevy <bhalevy@tonian.com>
Acked-by: Hillf Danton <dhillf@gmail.com>
Signed-off-by: Hugh Dickins <hughd@google.com>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/compaction.c')
0 files changed, 0 insertions, 0 deletions