summaryrefslogtreecommitdiffstats
path: root/mm
diff options
context:
space:
mode:
authorYue Hu2019-05-14 02:18:14 +0200
committerGreg Kroah-Hartman2019-06-15 11:54:01 +0200
commite5f8857ea972ef84a27a7990989d3388bc2d09c9 (patch)
tree8dca2b4c3549d45fe25b55af241449c10bc7b6f5 /mm
parentmem-hotplug: fix node spanned pages when we have a node with only ZONE_MOVABLE (diff)
downloadkernel-qcow2-linux-e5f8857ea972ef84a27a7990989d3388bc2d09c9.tar.gz
kernel-qcow2-linux-e5f8857ea972ef84a27a7990989d3388bc2d09c9.tar.xz
kernel-qcow2-linux-e5f8857ea972ef84a27a7990989d3388bc2d09c9.zip
mm/cma.c: fix crash on CMA allocation if bitmap allocation fails
[ Upstream commit 1df3a339074e31db95c4790ea9236874b13ccd87 ] f022d8cb7ec7 ("mm: cma: Don't crash on allocation if CMA area can't be activated") fixes the crash issue when activation fails via setting cma->count as 0, same logic exists if bitmap allocation fails. Link: http://lkml.kernel.org/r/20190325081309.6004-1-zbestahu@gmail.com Signed-off-by: Yue Hu <huyue2@yulong.com> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Laura Abbott <labbott@redhat.com> Cc: Mike Rapoport <rppt@linux.vnet.ibm.com> Cc: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'mm')
-rw-r--r--mm/cma.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/mm/cma.c b/mm/cma.c
index bfe9f5397165..6ce6e22f82d9 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -106,8 +106,10 @@ static int __init cma_activate_area(struct cma *cma)
cma->bitmap = kzalloc(bitmap_size, GFP_KERNEL);
- if (!cma->bitmap)
+ if (!cma->bitmap) {
+ cma->count = 0;
return -ENOMEM;
+ }
WARN_ON_ONCE(!pfn_valid(pfn));
zone = page_zone(pfn_to_page(pfn));