diff options
| author | David S. Miller | 2006-10-28 00:26:21 +0200 |
|---|---|---|
| committer | David S. Miller | 2006-10-31 00:24:34 +0100 |
| commit | 201a95afaa324b23188eeec268f6bb0b4b70b710 (patch) | |
| tree | b4821e52a74aefc2a3b766c43b32aaa83a3eca34 /net/appletalk | |
| parent | [NET] sealevel: uses arp_broken_ops (diff) | |
| download | kernel-qcow2-linux-201a95afaa324b23188eeec268f6bb0b4b70b710.tar.gz kernel-qcow2-linux-201a95afaa324b23188eeec268f6bb0b4b70b710.tar.xz kernel-qcow2-linux-201a95afaa324b23188eeec268f6bb0b4b70b710.zip | |
[APPLETALK]: Fix potential OOPS in atalk_sendmsg().
atrtr_find() can return NULL, so do not blindly dereference
rt->dev before we check for rt being NULL.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/appletalk')
| -rw-r--r-- | net/appletalk/ddp.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index 708e2e0371af..485e35c3b28b 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c @@ -1584,7 +1584,6 @@ static int atalk_sendmsg(struct kiocb *iocb, struct socket *sock, struct msghdr if (usat->sat_addr.s_net || usat->sat_addr.s_node == ATADDR_ANYNODE) { rt = atrtr_find(&usat->sat_addr); - dev = rt->dev; } else { struct atalk_addr at_hint; @@ -1592,7 +1591,6 @@ static int atalk_sendmsg(struct kiocb *iocb, struct socket *sock, struct msghdr at_hint.s_net = at->src_net; rt = atrtr_find(&at_hint); - dev = rt->dev; } if (!rt) return -ENETUNREACH; |