diff options
| author | David S. Miller | 2011-08-04 05:50:44 +0200 |
|---|---|---|
| committer | David S. Miller | 2011-08-07 03:33:19 +0200 |
| commit | 6e5714eaf77d79ae1c8b47e3e040ff5411b717ec (patch) | |
| tree | 30bd0d7a6a0a6ff0ace6da1835ae7b7167cce5e4 /net/dccp/ipv4.c | |
| parent | crypto: Move md5_transform to lib/md5.c (diff) | |
| download | kernel-qcow2-linux-6e5714eaf77d79ae1c8b47e3e040ff5411b717ec.tar.gz kernel-qcow2-linux-6e5714eaf77d79ae1c8b47e3e040ff5411b717ec.tar.xz kernel-qcow2-linux-6e5714eaf77d79ae1c8b47e3e040ff5411b717ec.zip | |
net: Compute protocol sequence numbers and fragment IDs using MD5.
Computers have become a lot faster since we compromised on the
partial MD4 hash which we use currently for performance reasons.
MD5 is a much safer choice, and is inline with both RFC1948 and
other ISS generators (OpenBSD, Solaris, etc.)
Furthermore, only having 24-bits of the sequence number be truly
unpredictable is a very serious limitation. So the periodic
regeneration and 8-bit counter have been removed. We compute and
use a full 32-bit sequence number.
For ipv6, DCCP was found to use a 32-bit truncated initial sequence
number (it needs 43-bits) and that is fixed here as well.
Reported-by: Dan Kaminsky <dan@doxpara.com>
Tested-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dccp/ipv4.c')
| -rw-r--r-- | net/dccp/ipv4.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c index 8c36adfd1919..332639b56f4d 100644 --- a/net/dccp/ipv4.c +++ b/net/dccp/ipv4.c @@ -26,6 +26,7 @@ #include <net/timewait_sock.h> #include <net/tcp_states.h> #include <net/xfrm.h> +#include <net/secure_seq.h> #include "ackvec.h" #include "ccid.h" |