diff options
| author | David Ahern | 2019-02-26 18:00:03 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2019-03-10 07:17:19 +0100 |
| commit | a68d31cc530649a714bd309dde6d12083231a518 (patch) | |
| tree | 401d8c8660ca4988d9c01d6dcabe462022dc81a2 /net/ipv6/route.c | |
| parent | ipv4: Return error for RTA_VIA attribute (diff) | |
| download | kernel-qcow2-linux-a68d31cc530649a714bd309dde6d12083231a518.tar.gz kernel-qcow2-linux-a68d31cc530649a714bd309dde6d12083231a518.tar.xz kernel-qcow2-linux-a68d31cc530649a714bd309dde6d12083231a518.zip | |
ipv6: Return error for RTA_VIA attribute
[ Upstream commit e3818541b49fb88650ba339d33cc53e4095da5b3 ]
IPv6 currently does not support nexthops outside of the AF_INET6 family.
Specifically, it does not handle RTA_VIA attribute. If it is passed
in a route add request, the actual route added only uses the device
which is clearly not what the user intended:
$ ip -6 ro add 2001:db8:2::/64 via inet 172.16.1.1 dev eth0
$ ip ro ls
...
2001:db8:2::/64 dev eth0 metric 1024 pref medium
Catch this and fail the route add:
$ ip -6 ro add 2001:db8:2::/64 via inet 172.16.1.1 dev eth0
Error: IPv6 does not support RTA_VIA attribute.
Fixes: 03c0566542f4c ("mpls: Netlink commands to add, remove, and dump routes")
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/ipv6/route.c')
| -rw-r--r-- | net/ipv6/route.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index cf4a8c25458f..ba59a9c14e02 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -4213,6 +4213,10 @@ static int rtm_to_fib6_config(struct sk_buff *skb, struct nlmsghdr *nlh, cfg->fc_gateway = nla_get_in6_addr(tb[RTA_GATEWAY]); cfg->fc_flags |= RTF_GATEWAY; } + if (tb[RTA_VIA]) { + NL_SET_ERR_MSG(extack, "IPv6 does not support RTA_VIA attribute"); + goto errout; + } if (tb[RTA_DST]) { int plen = (rtm->rtm_dst_len + 7) >> 3; |