diff options
author | Eric Dumazet | 2016-06-13 16:50:25 +0200 |
---|---|---|
committer | David S. Miller | 2016-06-15 21:16:30 +0200 |
commit | 0c5ddb51e8f7be7170600f95a4ea92e5a32afad8 (patch) | |
tree | a99bf1c6db2c7fdbd535102c8668070b45d01425 /net/sched/sch_prio.c | |
parent | Merge branch 'ovs-notifications' (diff) | |
download | kernel-qcow2-linux-0c5ddb51e8f7be7170600f95a4ea92e5a32afad8.tar.gz kernel-qcow2-linux-0c5ddb51e8f7be7170600f95a4ea92e5a32afad8.tar.xz kernel-qcow2-linux-0c5ddb51e8f7be7170600f95a4ea92e5a32afad8.zip |
net/mlx4_en: initialize cmd.context_lock spinlock earlier
Maciej Żenczykowski reported lockdep warning a spinlock
was not registered before being held in mlx4_cmd_wake_completions()
cmd.context_lock initialization is not at the right place.
1) mlx4_cmd_use_events() can be called multiple times.
Calling spin_lock_init() on a live spinlock can lead
to hangs.
2) mlx4_cmd_wake_completions() can be called while lock
has not been initialized.
Lockdep complains, and current logic is not race prone.
It seems better to move the initialization earlier in
mlx4_load_one()
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Maciej Żenczykowski <maze@google.com>
Cc: Eugenia Emantayev <eugenia@mellanox.com>
Cc: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_prio.c')
0 files changed, 0 insertions, 0 deletions