diff options
| author | Vlad Buslov | 2019-02-25 16:28:27 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2019-03-10 07:17:20 +0100 |
| commit | 3846080998b93b300237ed8cef5694f8cec5a4d0 (patch) | |
| tree | d7758c0dc959783ccab138bec07eed0bfcf07793 /net/sched | |
| parent | net/sched: act_skbedit: fix refcount leak when replace fails (diff) | |
| download | kernel-qcow2-linux-3846080998b93b300237ed8cef5694f8cec5a4d0.tar.gz kernel-qcow2-linux-3846080998b93b300237ed8cef5694f8cec5a4d0.tar.xz kernel-qcow2-linux-3846080998b93b300237ed8cef5694f8cec5a4d0.zip | |
net: sched: act_tunnel_key: fix NULL pointer dereference during init
[ Upstream commit a3df633a3c92bb96b06552c3f828d7c267774379 ]
Metadata pointer is only initialized for action TCA_TUNNEL_KEY_ACT_SET, but
it is unconditionally dereferenced in tunnel_key_init() error handler.
Verify that metadata pointer is not NULL before dereferencing it in
tunnel_key_init error handling code.
Fixes: ee28bb56ac5b ("net/sched: fix memory leak in act_tunnel_key_init()")
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Reviewed-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/sched')
| -rw-r--r-- | net/sched/act_tunnel_key.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/sched/act_tunnel_key.c b/net/sched/act_tunnel_key.c index 0f6601fdf889..72d9c432e8b4 100644 --- a/net/sched/act_tunnel_key.c +++ b/net/sched/act_tunnel_key.c @@ -377,7 +377,8 @@ static int tunnel_key_init(struct net *net, struct nlattr *nla, return ret; release_tun_meta: - dst_release(&metadata->dst); + if (metadata) + dst_release(&metadata->dst); err_out: if (exists) |