diff options
| author | Johannes Berg | 2016-01-26 11:29:03 +0100 |
|---|---|---|
| committer | Johannes Berg | 2016-01-26 11:32:05 +0100 |
| commit | 6736fde9672ff6717ac576e9bba2fd5f3dfec822 (patch) | |
| tree | 744a387ea6c9555b197842db8e87cd538ddfc958 /net/wireless | |
| parent | mac80211: Requeue work after scan complete for all VIF types. (diff) | |
| download | kernel-qcow2-linux-6736fde9672ff6717ac576e9bba2fd5f3dfec822.tar.gz kernel-qcow2-linux-6736fde9672ff6717ac576e9bba2fd5f3dfec822.tar.xz kernel-qcow2-linux-6736fde9672ff6717ac576e9bba2fd5f3dfec822.zip | |
rfkill: fix rfkill_fop_read wait_event usage
The code within wait_event_interruptible() is called with
!TASK_RUNNING, so mustn't call any functions that can sleep,
like mutex_lock().
Since we re-check the list_empty() in a loop after the wait,
it's safe to simply use list_empty() without locking.
This bug has existed forever, but was only discovered now
because all userspace implementations, including the default
'rfkill' tool, use poll() or select() to get a readable fd
before attempting to read.
Cc: stable@vger.kernel.org
Fixes: c64fb01627e24 ("rfkill: create useful userspace interface")
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/wireless')
0 files changed, 0 insertions, 0 deletions