summaryrefslogtreecommitdiffstats
path: root/net/x25
diff options
context:
space:
mode:
authorAlan Cox2009-03-27 08:28:21 +0100
committerDavid S. Miller2009-03-27 08:28:21 +0100
commit83e0bbcbe2145f160fbaa109b0439dae7f4a38a9 (patch)
treede3f516afc1878914855c9393b1e08c698ac378c /net/x25
parentappletalk: this warning can go I think (diff)
downloadkernel-qcow2-linux-83e0bbcbe2145f160fbaa109b0439dae7f4a38a9.tar.gz
kernel-qcow2-linux-83e0bbcbe2145f160fbaa109b0439dae7f4a38a9.tar.xz
kernel-qcow2-linux-83e0bbcbe2145f160fbaa109b0439dae7f4a38a9.zip
af_rose/x25: Sanity check the maximum user frame size
Otherwise we can wrap the sizes and end up sending garbage. Closes #10423 Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/x25')
-rw-r--r--net/x25/af_x25.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
index 9ca17b1ce52e..ed80af8ca5fb 100644
--- a/net/x25/af_x25.c
+++ b/net/x25/af_x25.c
@@ -1035,6 +1035,12 @@ static int x25_sendmsg(struct kiocb *iocb, struct socket *sock,
sx25.sx25_addr = x25->dest_addr;
}
+ /* Sanity check the packet size */
+ if (len > 65535) {
+ rc = -EMSGSIZE;
+ goto out;
+ }
+
SOCK_DEBUG(sk, "x25_sendmsg: sendto: Addresses built.\n");
/* Build a packet */