diff options
| author | Simon Derr | 2005-08-05 04:52:03 +0200 |
|---|---|---|
| committer | Linus Torvalds | 2005-08-05 06:43:14 +0200 |
| commit | 2f60f8d3573ff90fe5d75a6d11fd2add1248e7d6 (patch) | |
| tree | 173980b12459aa55586d3f4f56630abf5af1ffcc /net | |
| parent | [PATCH] tcp: fix TSO cwnd caching bug (diff) | |
| download | kernel-qcow2-linux-2f60f8d3573ff90fe5d75a6d11fd2add1248e7d6.tar.gz kernel-qcow2-linux-2f60f8d3573ff90fe5d75a6d11fd2add1248e7d6.tar.xz kernel-qcow2-linux-2f60f8d3573ff90fe5d75a6d11fd2add1248e7d6.zip | |
[PATCH] __vm_enough_memory() signedness fix
We have found what seems to be a small bug in __vm_enough_memory() when
sysctl_overcommit_memory is set to OVERCOMMIT_NEVER.
When this bug occurs the systems fails to boot, with /sbin/init whining
about fork() returning ENOMEM.
We hunted down the problem to this:
The deferred update mecanism used in vm_acct_memory(), on a SMP system,
allows the vm_committed_space counter to have a negative value.
This should not be a problem since this counter is known to be inaccurate.
But in __vm_enough_memory() this counter is compared to the `allowed'
variable, which is an unsigned long. This comparison is broken since it
will consider the negative values of vm_committed_space to be huge positive
values, resulting in a memory allocation failure.
Signed-off-by: <Jean-Marc.Saffroy@ext.bull.net>
Signed-off-by: <Simon.Derr@bull.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions