diff options
| author | Cong Wang | 2019-07-23 06:43:00 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2019-08-09 17:52:29 +0200 |
| commit | c4c8899376c2eb363c70b0b200434cc9abd3d34e (patch) | |
| tree | 8779d9cf557c51432c6b9ff22a5f867095b5710b /net | |
| parent | bnx2x: Disable multi-cos feature. (diff) | |
| download | kernel-qcow2-linux-c4c8899376c2eb363c70b0b200434cc9abd3d34e.tar.gz kernel-qcow2-linux-c4c8899376c2eb363c70b0b200434cc9abd3d34e.tar.xz kernel-qcow2-linux-c4c8899376c2eb363c70b0b200434cc9abd3d34e.zip | |
ife: error out when nla attributes are empty
[ Upstream commit c8ec4632c6ac9cda0e8c3d51aa41eeab66585bd5 ]
act_ife at least requires TCA_IFE_PARMS, so we have to bail out
when there is no attribute passed in.
Reported-by: syzbot+fbb5b288c9cb6a2eeac4@syzkaller.appspotmail.com
Fixes: ef6980b6becb ("introduce IFE action")
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sched/act_ife.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c index 06a3d4801878..915b6e94da63 100644 --- a/net/sched/act_ife.c +++ b/net/sched/act_ife.c @@ -484,6 +484,11 @@ static int tcf_ife_init(struct net *net, struct nlattr *nla, int ret = 0; int err; + if (!nla) { + NL_SET_ERR_MSG_MOD(extack, "IFE requires attributes to be passed"); + return -EINVAL; + } + err = nla_parse_nested(tb, TCA_IFE_MAX, nla, ife_policy, NULL); if (err < 0) return err; |