diff options
| author | Rafal Krypa | 2015-05-21 18:24:31 +0200 |
|---|---|---|
| committer | Casey Schaufler | 2015-06-02 20:53:23 +0200 |
| commit | 01fa8474fba7e80f6a2ac31d0790385a993cb7ba (patch) | |
| tree | 4166754ee9f03bc3cf36e6de5d3ebade43c176a1 /security/smack/smack.h | |
| parent | smack: pass error code through pointers (diff) | |
| download | kernel-qcow2-linux-01fa8474fba7e80f6a2ac31d0790385a993cb7ba.tar.gz kernel-qcow2-linux-01fa8474fba7e80f6a2ac31d0790385a993cb7ba.tar.xz kernel-qcow2-linux-01fa8474fba7e80f6a2ac31d0790385a993cb7ba.zip | |
Smack: fix seq operations in smackfs
Use proper RCU functions and read locking in smackfs seq_operations.
Smack gets away with not using proper RCU functions in smackfs, because
it never removes entries from these lists. But now one list will be
needed (with interface in smackfs) that will have both elements added and
removed to it.
This change will also help any future changes implementing removal of
unneeded entries from other Smack lists.
The patch also fixes handling of pos argument in smk_seq_start and
smk_seq_next. This fixes a bug in case when smackfs is read with a small
buffer:
Kernel panic - not syncing: Kernel mode fault at addr 0xfa0000011b
CPU: 0 PID: 1292 Comm: dd Not tainted 4.1.0-rc1-00012-g98179b8 #13
Stack:
00000003 0000000d 7ff39e48 7f69fd00
7ff39ce0 601ae4b0 7ff39d50 600e587b
00000010 6039f690 7f69fd40 00612003
Call Trace:
[<601ae4b0>] load2_seq_show+0x19/0x1d
[<600e587b>] seq_read+0x168/0x331
[<600c5943>] __vfs_read+0x21/0x101
[<601a595e>] ? security_file_permission+0xf8/0x105
[<600c5ec6>] ? rw_verify_area+0x86/0xe2
[<600c5fc3>] vfs_read+0xa1/0x14c
[<600c68e2>] SyS_read+0x57/0xa0
[<6001da60>] handle_syscall+0x60/0x80
[<6003087d>] userspace+0x442/0x548
[<6001aa77>] ? interrupt_end+0x0/0x80
[<6001daae>] ? copy_chunk_to_user+0x0/0x2b
[<6002cb6b>] ? save_registers+0x1f/0x39
[<60032ef7>] ? arch_prctl+0xf5/0x170
[<6001a92d>] fork_handler+0x85/0x87
Signed-off-by: Rafal Krypa <r.krypa@samsung.com>
Diffstat (limited to 'security/smack/smack.h')
0 files changed, 0 insertions, 0 deletions