diff options
| author | Sanskriti Sharma | 2018-10-02 16:29:11 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman | 2018-11-13 20:08:22 +0100 |
| commit | b2ad2430bd75dad1b0a708c833ebc41bb9aff0fd (patch) | |
| tree | b556b35c6c3234d6083cece3c438c1b826cb8340 /tools | |
| parent | perf tools: Free temporary 'sys' string in read_event_files() (diff) | |
| download | kernel-qcow2-linux-b2ad2430bd75dad1b0a708c833ebc41bb9aff0fd.tar.gz kernel-qcow2-linux-b2ad2430bd75dad1b0a708c833ebc41bb9aff0fd.tar.xz kernel-qcow2-linux-b2ad2430bd75dad1b0a708c833ebc41bb9aff0fd.zip | |
perf tools: Cleanup trace-event-info 'tdata' leak
[ Upstream commit faedbf3fd19f2511a39397f76359e4cc6ee93072 ]
Free tracing_data structure in tracing_data_get() error paths.
Fixes the following coverity complaint:
Error: RESOURCE_LEAK (CWE-772):
leaked_storage: Variable "tdata" going out of scope leaks the storage
Signed-off-by: Sanskriti Sharma <sansharm@redhat.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Cc: Joe Lawrence <joe.lawrence@redhat.com>
Link: http://lkml.kernel.org/r/1538490554-8161-3-git-send-email-sansharm@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/util/trace-event-info.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c index 7b0ca7cbb7de..8ad8e755127b 100644 --- a/tools/perf/util/trace-event-info.c +++ b/tools/perf/util/trace-event-info.c @@ -531,12 +531,14 @@ struct tracing_data *tracing_data_get(struct list_head *pattrs, "/tmp/perf-XXXXXX"); if (!mkstemp(tdata->temp_file)) { pr_debug("Can't make temp file"); + free(tdata); return NULL; } temp_fd = open(tdata->temp_file, O_RDWR); if (temp_fd < 0) { pr_debug("Can't read '%s'", tdata->temp_file); + free(tdata); return NULL; } |