summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* staging: dgap: Add Mark Hounschell to maintainers list for dgapMark Hounschell2014-05-151-0/+1
| | | | | | | | | Add Mark Hounschell to the MAINTAINERs list for the dgap driver Signed-off-by: Mark Hounschell <markh@compro.net> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: vt6656: fix potential leak in vt6656_hostap_ioctl()Christian Engelmayer2014-05-151-2/+4
| | | | | | | | | | | Commit fb841d67 (staging: vt6656: don't leak 'param' in vt6656_hostap_ioctl() when returning -EOPNOTSUPP) cleaned up direct returns in the ioctl switch statement that leaked already allocated memory. Fix the same issue for VIAWGET_HOSTAPD_SCAN_REQ and VIAWGET_HOSTAPD_MLME that are not supported by this driver. Detected by Coverity - CID 144381. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: vt6656: desh.h Remove unused macros and structures.Malcolm Priestley2014-05-151-55/+0Star
| | | | | | | All are dead and of no use. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: vt6656: rxtx: Remove unused uDMAIdx from driver.Malcolm Priestley2014-05-154-22/+19Star
| | | | | | | Remove from functions and callers. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: vt6656: make spin_lock_irq() human readableMartin Kepplinger2014-05-152-3/+4
| | | | | | | | | | | Don't require FIRMWAREbDownload() to, first off, unlock a held lock. Thus do all locking in main_usb.c and hold it for a insignificantly shorter period of time. This makes the affected area significantly more readable though. Signed-off-by: Martin Kepplinger <martink@posteo.de> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: vt6655: fix checkpatch bracing issuesGuido Martínez2014-05-1523-949/+814Star
| | | | | | | | | | | | | | | | | This patchs fixes tons of warnings such as: WARNING: braces {} are not necessary for single statement blocks #354: FILE: drivers/staging/vt6655/wmgr.c:354: + for (ii = 0; ii < WLAN_BSSID_LEN; ii++) { + pMgmt->abyDesireBSSID[ii] = 0xFF; + } Please note: this patch only fixes bracing issues (and there is still a lot to do); so if you run checkpatch it _will_ throw a lot of errors. Use --test-only=braces Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: vt6655: remove dead codeGuido Martínez2014-05-1539-1101/+51Star
| | | | | | | Remove dead code in many places on this driver. Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: vt6656: Use proper target pointer in memcpy()Tobias Klauser2014-05-151-2/+2
| | | | | | | | | | | | | | The coverity scanner marked these two memcpy()'s as causing a buffer overflow in CIDs 142743 and 142744. This is due the h_dest member of struct ethhdr being used as a target (size ETH_ALEN) in memcpy, but the copy is of size ETH_HLEN. However, the intention here seems to be to copy the entire ethernet header. Make that clear by specifying the proper destination buffer. Also remove the unnecessary casts of the source argument. Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: vt6656: Remove unnecesssary NULL checkTobias Klauser2014-05-151-3/+0Star
| | | | | | | | | | | | | | pFifoHead points to tx_buffer->fifo_head which can never be NULL. We also don't need to check for tx_buffer being NULL instead, since it always points to ->Data of struct vnt_usb_send_context - the pointer to which was checked before calling s_vGenerateTxParameter(). Silences a dereference before NULL check warning reported by the coverity scanner in CID 1127221. Cc: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Staging: vt6655: tether: fixed a brace coding style issueNicolas Del Piano2014-05-151-2/+2
| | | | | | | Fixed a coding style issue. Signed-off-by: Nicolas Del Piano <ndel314@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish: clean up the pipe driver 64bit ifdefsAlan2014-05-151-22/+11Star
| | | | | | | | Use the 64bit helper method to scrub most of the ifdefs from the driver. The pipe reading has a funny case we can't scrub completely. Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish: clean up the checkpatch warningsAlan2014-05-151-26/+34
| | | | | | | Mostly spacing changes, also making the operations structure const Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish: clean up tty 64bit supportAlan2014-05-151-10/+5Star
| | | | | | | Use the helper we now have available. Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish: clean up staging ifdefsAlan2014-05-153-40/+13Star
| | | | | | | Use the write helpers and add an audio helper Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish: Allow 64bit buildsAlan2014-05-151-1/+0Star
| | | | | | | We can now enable the 64bit option for the Goldfish 64bit emulator. Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish: enable 64-bit tty driverJun Tian2014-05-151-0/+9
| | | | | | Signed-off-by: Jun Tian <jun.j.tian@intel.com> Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish_nand.c: remove length restrictionsNick Kralevich2014-05-151-4/+0Star
| | | | | | | | | | | | | | | Remove limitations on the size of a read / write request. AFAIK, there's no consequence to allowing the upper layers to specify different read / write sizes. This is needed to support running ext4 on goldfish. Bug: https://code.google.com/p/android/issues/detail?id=38561 Signed-off-by: Nick Kralevich <nnk@google.com> Signed-off-by: Jun Tian <jun.j.tian@intel.com> Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish: add support for 64bit to the virtual busOctavian Purdila2014-05-151-1/+5
| | | | | | | | | | This patchs adds a new register to pass the upper 32bits for the device name address when running in 64bit mode. Signed-off-by: Octavian Purdila <octavian.purdila@intel.com> Signed-off-by: Jun Tian <jun.j.tian@intel.com> Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish: fix kernel panic when using multiple adb connectionJun Tian2014-05-151-0/+3
| | | | | | | | | When using multiple adb on 64 bit kernel to transfer data, the goldfish pipe interrupt will crash the kernel. Signed-off-by: Jun Tian <jun.j.tian@intel.com> Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish: 64-bit pipe driver for goldfish platformJun Tian2014-05-151-6/+29
| | | | | | | | | | Support 64-bit channel and address for the goldfish pipe driver. Signed-off-by: Jun Tian <jun.j.tian@intel.com> Signed-off-by: Octavian Purdila <octavian.purdila@intel.com> Signed-off-by: Brian Wood <brian.j.wood@intel.com> Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Remove unused pointer in rtw_wdev_free()Christian Engelmayer2014-05-151-4/+0Star
| | | | | | | Pointer 'pwdev_priv' in function rtw_wdev_free() is unused - thus remove it. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: fix some confusing indentingDan Carpenter2014-05-151-2/+2
| | | | | | | | | The break and the "unknown++" are at the same indent level so my static checker complains. The if statement should be indented more. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Remove unused struct odm_ra_infoJes Sorensen2014-05-151-32/+0Star
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Since struct odm_sta_info isn't used, remove it completelyJes Sorensen2014-05-151-25/+0Star
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Remove unused variable IOTPeerJes Sorensen2014-05-152-2/+0Star
| | | | | | | | For bizarre reason we have unused variables IOTPeer both in struct sta_info and struct odm_sta_info. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: struct odm_mac_info isn't usedJes Sorensen2014-05-151-6/+0Star
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: struct phy_info and struct odm_phy_info are identicalJes Sorensen2014-05-155-23/+10Star
| | | | | | | | We don't need two copies of the same struct, it just leads to pointless typecasts. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Remove empty *_free_xmit_priv() and friendsJes Sorensen2014-05-156-15/+0Star
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Eliminate no-op function rtl8723au_init_recvbuf()Jes Sorensen2014-05-153-8/+0Star
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Remove another unused queue from struct recv_privJes Sorensen2014-05-153-8/+0Star
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Remove some unused lists from struct sta_privJes Sorensen2014-05-152-4/+0Star
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: rtw_pwrctrl.c: Reduce spaghettificationJes Sorensen2014-05-151-104/+111
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: pattrib->priority can't be > 15, no need for CHKBIT()Jes Sorensen2014-05-151-2/+1Star
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: qos_asm23a(): Don't pass through an invalid priorityJes Sorensen2014-05-151-0/+1
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: set_qos() keep userpriority in a u8Jes Sorensen2014-05-151-1/+1
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Another case of missing 'tid' bounds checking.Jes Sorensen2014-05-152-1/+6
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: 'keyid' is always 0-3, no need for CHKBIT()Jes Sorensen2014-05-153-9/+20
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: No need for CHKBIT since 16 + 12 is still < 32Jes Sorensen2014-05-151-3/+3
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: tid is 4 bits, so we need a 16 bit value to hold a bitmapJes Sorensen2014-05-154-19/+14Star
| | | | | | | | | | | Remove unused add_enable_bitmap and candidate_tid_bitmap from struct mlme_ext_info. In addition we don't need to use CHKBIT when we know we are dealing with a value in the range 0-15. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Remove local #define BIT()Jes Sorensen2014-05-151-3/+0Star
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Call c2h_handler_8723a() directly instead of via HAL ↵Jes Sorensen2014-05-155-17/+5Star
| | | | | | | interface Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: The driver only has one c2h_id_filterJes Sorensen2014-05-155-17/+1Star
| | | | | | | | Since we only have one function for this, there is no point in keeping the HAL silliness. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: c2h_evt_hdl() is always called with 3rd argument = NULLJes Sorensen2014-05-151-13/+4Star
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Declare c2h_evt_hdl staticJes Sorensen2014-05-152-5/+3Star
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Move rtw_do_join23a() prototype to rtw_ioctl_set.hJes Sorensen2014-05-153-3/+1Star
| | | | | | | | rtw_do_join23a() is declared in rtw_ioctl_set.c so move the prototype to it's correct place, and remove duplicate protoype from rtw_mlme.c Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Move {WPA,RSN}_TKIP_CIPHER23A to rtw_wlan_util.c and ↵Jes Sorensen2014-05-153-8/+5Star
| | | | | | | mark them static Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Move REALTEK96B_IE23A to rtw_mlme_ext.c and mark it staticJes Sorensen2014-05-153-5/+3Star
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Remove unused ADPT_{FMT,AGR} macrosJes Sorensen2014-05-151-4/+0Star
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Get rid of FUNC_NDEV_{FMT,ARG}Jes Sorensen2014-05-157-69/+61Star
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: rtl8723au: Remove FUNC_ADPT_{FMT,ARG}Jes Sorensen2014-05-157-96/+79Star
| | | | | Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>