summaryrefslogtreecommitdiffstats
path: root/drivers/staging/wlags49_h2
Commit message (Collapse)AuthorAgeFilesLines
* staging: wlags49_h2: wl_priv: Remove useless return variablesPeter Senna Tschudin2014-05-231-10/+4Star
| | | | | | | | | | | | | | | | | | | | | | | | This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: make return of 0 explicitJulia Lawall2014-05-231-9/+2Star
| | | | | | | | | | | | | | | | | | | | | | | | | | Delete unnecessary local variable whose value is always 0 and that hides the fact that the result is always 0. A simplified version of the semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ local idexpression ret; expression e; position p; @@ -ret = 0; ... when != ret = e return - ret + 0 ; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-nextLinus Torvalds2014-04-031-3/+3
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pull networking updates from David Miller: "Here is my initial pull request for the networking subsystem during this merge window: 1) Support for ESN in AH (RFC 4302) from Fan Du. 2) Add full kernel doc for ethtool command structures, from Ben Hutchings. 3) Add BCM7xxx PHY driver, from Florian Fainelli. 4) Export computed TCP rate information in netlink socket dumps, from Eric Dumazet. 5) Allow IPSEC SA to be dumped partially using a filter, from Nicolas Dichtel. 6) Convert many drivers to pci_enable_msix_range(), from Alexander Gordeev. 7) Record SKB timestamps more efficiently, from Eric Dumazet. 8) Switch to microsecond resolution for TCP round trip times, also from Eric Dumazet. 9) Clean up and fix 6lowpan fragmentation handling by making use of the existing inet_frag api for it's implementation. 10) Add TX grant mapping to xen-netback driver, from Zoltan Kiss. 11) Auto size SKB lengths when composing netlink messages based upon past message sizes used, from Eric Dumazet. 12) qdisc dumps can take a long time, add a cond_resched(), From Eric Dumazet. 13) Sanitize netpoll core and drivers wrt. SKB handling semantics. Get rid of never-used-in-tree netpoll RX handling. From Eric W Biederman. 14) Support inter-address-family and namespace changing in VTI tunnel driver(s). From Steffen Klassert. 15) Add Altera TSE driver, from Vince Bridgers. 16) Optimizing csum_replace2() so that it doesn't adjust the checksum by checksumming the entire header, from Eric Dumazet. 17) Expand BPF internal implementation for faster interpreting, more direct translations into JIT'd code, and much cleaner uses of BPF filtering in non-socket ocntexts. From Daniel Borkmann and Alexei Starovoitov" * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next: (1976 commits) netpoll: Use skb_irq_freeable to make zap_completion_queue safe. net: Add a test to see if a skb is freeable in irq context qlcnic: Fix build failure due to undefined reference to `vxlan_get_rx_port' net: ptp: move PTP classifier in its own file net: sxgbe: make "core_ops" static net: sxgbe: fix logical vs bitwise operation net: sxgbe: sxgbe_mdio_register() frees the bus Call efx_set_channels() before efx->type->dimension_resources() xen-netback: disable rogue vif in kthread context net/mlx4: Set proper build dependancy with vxlan be2net: fix build dependency on VxLAN mac802154: make csma/cca parameters per-wpan mac802154: allow only one WPAN to be up at any given time net: filter: minor: fix kdoc in __sk_run_filter netlink: don't compare the nul-termination in nla_strcmp can: c_can: Avoid led toggling for every packet. can: c_can: Simplify TX interrupt cleanup can: c_can: Store dlc private can: c_can: Reduce register access can: c_can: Make the code readable ...
| * wlags49_h2: Call dev_kfree/consume_skb_any instead of dev_kfree_skb.Eric W. Biederman2014-03-251-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | Replace dev_kfree_skb with dev_consume_skb_any in wl_send and wl_send_dma which can be called in hard irq and other contexts, on the code paths where the skb was transmitted successfully. Replace dev_kfree_skb with dev_kfree_skb_any in wl_send_dmay which can be called in hard irq and other contexts, on the code path where a skb is dropped. Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
* | staging: wlags49_h2: Delete unnecessary bracesJelena Bjelja2014-03-191-16/+8Star
| | | | | | | | | | | | | | | | Fix the following checkpatch.pl warnings in wl_netdev.c: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Jelena Bjelja <jelena.bjelja.ing@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: wlags49_h2: Do not use assignment in if conditionJelena Bjelja2014-03-191-1/+2
| | | | | | | | | | | | | | | | Fix the following checkpatch.pl issue in wl_netdev.c: ERROR: do not use assignment in if condition Signed-off-by: Jelena Bjelja <jelena.bjelja.ing@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: wlags49_h2: Enclose macro in a do-while loopJelena Bjelja2014-03-191-3/+5
| | | | | | | | | | | | | | | | | | Fix the following checkpatch.pl issues in wl_netdev.c: ERROR: Macros with multiple statements should be enclosed in a do - while loop Signed-off-by: Jelena Bjelja <jelena.bjelja.ing@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: wlags49_h2: Correct comment style in wl_netdev.cMathieu Maret2014-03-191-69/+89
| | | | | | | | | | | | | | Code is using C99 code style, so change them to kernel style Signed-off-by: Mathieu Maret <mathieu.maret@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: wlags49_h2: remove commented code in wl_netdev.cMathieu Maret2014-03-191-38/+0Star
| | | | | | | | | | | | | | Remove unused code under C99 comment style Signed-off-by: Mathieu Maret <mathieu.maret@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: wlags49_h2: reindent wl_netdev.cMathieu Maret2014-03-191-950/+999
| | | | | | | | | | | | | | | | As the file is using a mix between space and tab, and space instead of tab, use Lindent to fix the file Signed-off-by: Mathieu Maret <mathieu.maret@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: wlags49_h2: Fix sparse warning for static declarationJelena Bjelja2014-03-181-1/+1
| | | | | | | | | | | | | | | | | | | | Fix the following sparse warning: drivers/staging/wlags49_h2/wl_netdev.c:533:6: warning: symbol 'wl_poll' was not declared. Should it be static? Signed-off-by: Jelena Bjelja <jelena.bjelja.ing@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging:wlags49_h2: Removed assignments from if statements.Chi Pham2014-03-101-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following coccinelle script found the match: @@ expression E0, E1, E2; statement S0, S1; @@ - if ((E1 = E2) != E0) + E1 = E2; + if (E1 != E0) S0 else S1 Signed-off-by: Chi Pham <fempsci@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
* | Staging:wlags49_h25: Fix sparse warning for static declarationsEbru Akagunduz2014-03-071-1/+1
| | | | | | | | | | | | | | | | | | This patch fixes the Sparse Warnings "symbol was not declared. Should it be static?" Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | Staging: wlags49_h2: Fix incorrect type in assignment in wl_wext.cMonam Agarwal2014-03-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes following sparse warnings: drivers/staging/wlags49_h2/wl_wext.c:3357:28: warning: incorrect type in assignment (different address spaces) drivers/staging/wlags49_h2/wl_wext.c:3357:28: expected void [noderef] <asn:1>*[addressable] [assigned] pointer drivers/staging/wlags49_h2/wl_wext.c:3357:28: got void *<noident> drivers/staging/wlags49_h2/wl_wext.c:3422:47: warning: incorrect type in assignment (different address spaces) drivers/staging/wlags49_h2/wl_wext.c:3422:47: expected void [noderef] <asn:1>*[addressable] [assigned] pointer drivers/staging/wlags49_h2/wl_wext.c:3422:47: got char *[usertype] <noident> drivers/staging/wlags49_h2/wl_wext.c:3781:21: warning: symbol 'wl_priv_args' was not declared. Should it be static? Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | Staging: wlags49_h2: Fix Sparse Warning for Static Declarations in dhf.cMonam Agarwal2014-03-071-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | This patch fixes the following sparse warnings: drivers/staging/wlags49_h2/dhf.c:109:6: warning: symbol 'signature' was not declared. Should it be static? drivers/staging/wlags49_h2/dhf.c:126:25: warning: symbol 'mfi_sup' was not declared. Should it be static? drivers/staging/wlags49_h2/dhf.c:127:25: warning: symbol 'cfi_sup' was not declared. Should it be static? drivers/staging/wlags49_h2/dhf.c:142:17: warning: symbol 'ltv_info' was not declared. Should it be static? drivers/staging/wlags49_h2/dhf.c:173:1: warning: symbol 'check_comp_fw' was not declared. Should it be static? Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | Staging: wlags49_h2: Fix Sparse Warning for Static Declarations in hcf.cMonam Agarwal2014-03-071-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes following sparse warnings: drivers/staging/wlags49_h2/hcf.c:253:26: warning: symbol 'cfg_drv_identity' was not declared. Should it be static? drivers/staging/wlags49_h2/hcf.c:262:24: warning: symbol 'cfg_drv_sup_range' was not declared. Should it be static? drivers/staging/wlags49_h2/hcf.c:274:31: warning: symbol 'cfg_drv_act_ranges_pri' was not declared. Should it be static? drivers/staging/wlags49_h2/hcf.c:291:31: warning: symbol 'cfg_drv_act_ranges_sta' was not declared. Should it be static? drivers/staging/wlags49_h2/hcf.c:336:31: warning: symbol 'cfg_drv_act_ranges_hsi' was not declared. Should it be static? drivers/staging/wlags49_h2/hcf.c:373:24: warning: symbol 'cfg_drv_act_ranges_apf' was not declared. Should it be static? drivers/staging/wlags49_h2/hcf.c:3103:1: warning: symbol 'calc_mic' was not declared. Should it be static? drivers/staging/wlags49_h2/hcf.c:3419:1: warning: symbol 'check_mic' was not declared. Should it be static? Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | Staging: wlags49_h2: Fix Remove unused functions in wl_util.cMonam Agarwal2014-03-071-37/+0Star
| | | | | | | | | | | | | | This patch removes the unused function "percent" from wl_util.c Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging:wlags49_h2: Remove unnecessary braces in if statementsHimangi Saraogi2014-03-071-50/+31Star
| | | | | | | | | | | | | | | | This patch fixes the checkpatch warnings: WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging:wlags49_h2: Remove unnecessary spaces around parenthesesHimangi Saraogi2014-03-071-65/+65
| | | | | | | | | | | | | | | | | | This patch fixes the following checkpatch errors: ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging:wlags49_h2:fix conditional statement warningsHimangi Saraogi2014-03-071-2/+1Star
| | | | | | | | | | | | | | | | | | This patch fixes the following warnings: WARNING: that open brace { should be on the previous line WARNING: suspect code indent for conditional statements (16, 16) Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging:wlags49_h2:change include path for uaccess.hHimangi Saraogi2014-03-071-1/+1
| | | | | | | | | | | | | | | | This patch fixes the following issue detected by checkpatch.pl. WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h> Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging:wlags49_h2: change comment styleHimangi Saraogi2014-03-071-52/+40Star
| | | | | | | | | | | | | | | | | | Coding style requires that comments use the standard /* */ style instead of C99 style. The commented #include statements were also removed as they are not required. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | Staging: wlags49_h2: Fix sparse warnings in sta_h2.cMonam Agarwal2014-03-071-1/+1
|/ | | | | | | | | This patch fixes sparse warnings "Using plain integer as NULL pointer" in sta_h2.c Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* wlags49_h2: Fix overflow in wireless_set_essid()Maurizio Lombardi2014-02-071-1/+1
| | | | | | | | This patch prevents the wireless_set_essid() function from overwriting the last byte of the NetworkName buffer which must be NULL. Signed-off-by: Maurizio Lombardi <mlombard@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: Fix "do not use C99 //" in wl_cs.h, wl_enc.h wl_main.h ↵Masanari Iida2014-01-144-5/+5
| | | | | | | | | | and wl_wext.h This patch fixed "Error: do not use C99 //" found by checkpatch.pl in multiple files within wlags49_h2. Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: remove wl_pci.?Greg Kroah-Hartman2014-01-092-1587/+0Star
| | | | | | These files aren't being built into anything, so remove them. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: debug.h: remove typedef for debug structureGreg Kroah-Hartman2014-01-0910-74/+6Star
| | | | | | | Also move the variable definition into the .h file, so it doesn't have to be declared in each .c file individually, which is crazy. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: debug.h: fix up some coding style issues.Greg Kroah-Hartman2014-01-091-4/+5
| | | | | | Minor stuff, just formatting. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: remove some DBG_TRACE() callsGreg Kroah-Hartman2014-01-091-11/+1Star
| | | | | | These two calls were not needed, they were just debugging stuff. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: remove custom ways of creating a module nameGreg Kroah-Hartman2014-01-094-23/+4Star
| | | | | | | Just use KBUILD_MODNAME, don't try to hand-roll the same thing with odd logic. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: remove PRINTK()Greg Kroah-Hartman2014-01-091-7/+2Star
| | | | | | It was just a call to printk() so make that instead. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: remove DBG_DEFN()Greg Kroah-Hartman2014-01-091-1/+0Star
| | | | | | It didn't do anything, and no one called it, so remove it. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: remove DBG_TRAP()Greg Kroah-Hartman2014-01-091-8/+0Star
| | | | | | It didn't do anything, so just remove it, it's useless. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: remove DBG_LEAVE()Greg Kroah-Hartman2014-01-099-245/+7Star
| | | | | | | We have an in-kernel tracing function, use that instead if you really need to figure out when functions are called and exited. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: remove DBG_ENTER() macroGreg Kroah-Hartman2014-01-099-369/+8Star
| | | | | | | We have an in-kernel tracing function, please use that instead of custom macros. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: remove empty DBG_FUNC()Greg Kroah-Hartman2014-01-099-137/+0Star
| | | | | | | DBG_FUNC() didn't even do anything, so no need for it to be present in the code at all. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: remove some unused macrosGreg Kroah-Hartman2014-01-091-4/+0Star
| | | | | | | These macros were commented out, so just delete them as they are not used anywhere. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: remove unneeded MODULE_DATE stringGreg Kroah-Hartman2014-01-091-5/+2Star
| | | | | | | This string makes no sense now that the driver is in the kernel, so remove it. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: Drop debug macro recording build date/timeJosh Triplett2014-01-091-4/+0Star
| | | | | | | | | The kernel already has this information, and individual drivers shouldn't duplicate that. This also eliminates the use of __DATE__ and __TIME__, which make the build non-deterministic. Signed-off-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: delete non-required instances of include <linux/init.h>Paul Gortmaker2013-12-171-1/+0Star
| | | | | | | | | | None of these files are actually using any __init type directives and hence don't need to include <linux/init.h>. Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* Merge branch 'opw-next' into staging-nextGreg Kroah-Hartman2013-11-221-3/+3
|\ | | | | | | | | | | | | | | This pulls in all of the staging patches applied during the opw application process, and some other staging patches that were submitted during that period of time. All of these are for 3.14-rc1. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging:wlags49_h2: Fix sparse warnings in sta_h25.cHimangi Saraogi2013-11-101-3/+3
| | | | | | | | | | | | | | | | | | This patch fixes sparse warnings "Using plain integer as NULL pointer" in sta_h25.c Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | Merge tag 'staging-3.13-rc1' of ↵Linus Torvalds2013-11-072-13/+13
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging Pull staging driver update from Greg KH: "Here's the big drivers/staging/ update for 3.13-rc1. Nothing major here, just a _ton_ of fixes and cleanups, mostly driven by the new round of OPW applicants, but also there are lots of other people doing staging tree cleanups these days in order to help get the drivers into mergable shape. We also merge, and then revert, the ktap code, as Ingo and the other perf/ftrace developers feel it should go into the "real" part of the kernel with only a bit more work, so no need to put it in staging for now. All of this has been in linux-next for a while with no reported issues" * tag 'staging-3.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (1045 commits) staging: drm/imx: fix return value check in ipu_add_subdevice_pdata() Staging: zram: Fix access of NULL pointer Staging: zram: Fix variable dereferenced before check Staging: rtl8187se: space prohibited before semicolon in r8185b_init.c Staging: rtl8187se: fix space prohibited after that open parenthesis '(' in r8185b_init.c Staging: rtl8187se: fix braces {} are not necessary for single statement blocks in r8185b_init.c Staging: rtl8187se: fix trailing whitespace in r8185b_init.c Staging: rtl8187se: fix please, no space before tabs in r8185b_init.c drivers/staging/nvec/Kconfig: remove trailing whitespace Staging: dwc2: Fix variable dereferenced before check Staging: xgifb: fix braces {} are not necessary for any arm of this statement staging: rtl8192e: remove unneeded semicolons staging: rtl8192e: use true and false for bool variables staging: ft1000: return values corrected in scram_start_dwnld staging: ft1000: change values of status return variable in write_dpram32_and_check staging: bcm: Remove unnecessary pointer casting imx-drm: ipuv3-crtc: Invert IPU DI0 clock polarity staging: r8188eu: Fix sparse warnings in rtl_p2p.c staging: r8188eu: Fix sparse warnings in rtw_mlme_ext.c staging: r8188eu: Fix sparse warnings in rtl8188e.cmd.c ...
| * staging: wlags49_h2: Fixes the sparse warning in sta_h2.cArchana kumari2013-10-191-2/+2
| | | | | | | | | | | | | | | | | | This patch fixes sparse warning "Using plain integer as NULL pointer" in sta_h2.c Signed-off-by: Archana kumari <archanakumari959@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| * staging: wlags49_h2: fixed space prohibited warnings in hcf.hArchana kumari2013-10-191-11/+11
| | | | | | | | | | | | | | | | | | | | | | This patch fixes the following warnings in hcf.c: "space prohibited between function name and open parenthesis '(' " "space prohibited before that close parenthesis ')' ". Signed-off-by: Archana kumari <archanakumari959@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | staging: wlags49_h2: buffer overflow setting station nameDan Carpenter2013-10-301-3/+6
|/ | | | | | | | | | | | | | We need to check the length parameter before doing the memcpy(). I've actually changed it to strlcpy() as well so that it's NUL terminated. You need CAP_NET_ADMIN to trigger these so it's not the end of the world. Reported-by: Nico Golde <nico@ngolde.de> Reported-by: Fabian Yamaguchi <fabs@goesec.de> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: stable@kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
* staging: wlags49_h2: remove sysfs fileGreg Kroah-Hartman2013-08-245-152/+0Star
| | | | | | | | | | | | | The sysfs file in this driver is showing a raft of debugging values, none of which belong in sysfs, let alone in a single sysfs file. If these really need to be described somewhere, they should go into debugfs. For now, just delete the sysfs file, which removes a bunch of files from the tree. Cc: Henk de Groot <pe1dnn@amsat.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: fix error return code in wl_adapter_insert()Wei Yongjun2013-05-181-1/+2
| | | | | | | | | | | | | When return from wl_adapter_insert() in the register_netdev() error handling case, 'ret' which is 0 is returned, but we should return a negative error code instead, so fix to return the return value of register_netdev(). Introduce by commit 657d4c86d4cd85a4696445f6fb2fe0941a5724ff (staging: wlags49_h2: fix error handling in pcmcia probe function) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: fix up "205179d staging: wlags49_h2: strncpy, need ↵Chen Gang2013-05-171-1/+2
| | | | | | | | | | | | | | | | checking the memory length" for avoiding warnings Type of 'probe_rsp->rawData[1]' is 'hcf_8' which is 'u8', it will compare with 'int', so use min_t() to cast to 'u8' to avoid related warning. If use min(), it has '(void) (&_min1 == &_min2);', so if no type cast, the compiler will report 'pointer types lacks a cast': drivers/staging/wlags49_h2/wl_main.c:3174:122: warning: comparison of distinct pointer types lacks a cast [enabled by default] Signed-off-by: Chen Gang <gang.chen@asianux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlags49_h2: strncpy, need checking the memory lengthChen Gang2013-05-141-1/+2
| | | | | | | | HCF_MAX_NAME_LEN is 32, which may less than ''probe_rsp->rawData[1]'', so need check the length when copy to ssid. Signed-off-by: Chen Gang <gang.chen@asianux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3-55-g7522 (git 2.39.0) at 2024-07-13 23:58:09 +0200