From e89bec3a9811563cc41b9d25443a07c883ab8950 Mon Sep 17 00:00:00 2001 From: Naveen Kumar Parna Date: Fri, 17 May 2019 10:04:55 +0530 Subject: char: misc: Move EXPORT_SYMBOL immediately next to the functions/varibles According to checkpatch: EXPORT_SYMBOL(foo); should immediately follow its function/variable. This patch fixes the following checkpatch.pl issues in drivers/char/misc.c: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable Signed-off-by: Naveen Kumar Parna Signed-off-by: Greg Kroah-Hartman --- drivers/char/misc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'drivers/char') diff --git a/drivers/char/misc.c b/drivers/char/misc.c index 53cfe574d8d4..f6a147427029 100644 --- a/drivers/char/misc.c +++ b/drivers/char/misc.c @@ -226,6 +226,7 @@ int misc_register(struct miscdevice *misc) mutex_unlock(&misc_mtx); return err; } +EXPORT_SYMBOL(misc_register); /** * misc_deregister - unregister a miscellaneous device @@ -249,8 +250,6 @@ void misc_deregister(struct miscdevice *misc) clear_bit(i, misc_minors); mutex_unlock(&misc_mtx); } - -EXPORT_SYMBOL(misc_register); EXPORT_SYMBOL(misc_deregister); static char *misc_devnode(struct device *dev, umode_t *mode) -- cgit v1.2.3-55-g7522 From 7256d7f401bdc9d3bd37c5de5f9b5f4f7e2de511 Mon Sep 17 00:00:00 2001 From: Naveen Kumar Parna Date: Wed, 15 May 2019 21:47:46 +0530 Subject: bsr: do not use assignment in if condition checkpatch.pl does not like assignment in if condition Signed-off-by: Naveen Kumar Parna Reviewed-by: Mukesh Ojha Signed-off-by: Greg Kroah-Hartman --- drivers/char/bsr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'drivers/char') diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c index a6cef548e01e..70de334554a8 100644 --- a/drivers/char/bsr.c +++ b/drivers/char/bsr.c @@ -322,7 +322,8 @@ static int __init bsr_init(void) goto out_err_2; } - if ((ret = bsr_create_devs(np)) < 0) { + ret = bsr_create_devs(np); + if (ret < 0) { np = NULL; goto out_err_3; } -- cgit v1.2.3-55-g7522 From 687685a3f246756a2a8c0d45820be42066ffce05 Mon Sep 17 00:00:00 2001 From: Naveen Kumar Parna Date: Fri, 17 May 2019 10:20:07 +0530 Subject: bsr: "foo * bar" should be "foo *bar" Fixed the checkpatch error. Used "foo *bar" instead of "foo * bar" Signed-off-by: Naveen Kumar Parna Signed-off-by: Greg Kroah-Hartman --- drivers/char/bsr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/char') diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c index 70de334554a8..935d4b300340 100644 --- a/drivers/char/bsr.c +++ b/drivers/char/bsr.c @@ -147,7 +147,7 @@ static int bsr_mmap(struct file *filp, struct vm_area_struct *vma) return 0; } -static int bsr_open(struct inode * inode, struct file * filp) +static int bsr_open(struct inode *inode, struct file *filp) { struct cdev *cdev = inode->i_cdev; struct bsr_dev *dev = container_of(cdev, struct bsr_dev, bsr_cdev); -- cgit v1.2.3-55-g7522