From 1760435d613c9ee536eaf40ffa97958c3e1973fe Mon Sep 17 00:00:00 2001 From: Suwan Kim Date: Wed, 30 Jan 2019 23:48:28 +0900 Subject: usb: core: Move variable initialization to appropriate place It is better to initialize the variable 'cfgno' in the for loop than at the current place. Signed-off-by: Suwan Kim Acked-by: Alan Stern Signed-off-by: Greg Kroah-Hartman --- drivers/usb/core/config.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'drivers/usb/core/config.c') diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c index 4a0945c04b4c..7bb6b1bd06c8 100644 --- a/drivers/usb/core/config.c +++ b/drivers/usb/core/config.c @@ -805,7 +805,6 @@ int usb_get_configuration(struct usb_device *dev) unsigned char *bigbuffer; struct usb_config_descriptor *desc; - cfgno = 0; if (ncfg > USB_MAXCONFIG) { dev_warn(ddev, "too many configurations: %d, " "using maximum allowed: %d\n", ncfg, USB_MAXCONFIG); @@ -831,7 +830,7 @@ int usb_get_configuration(struct usb_device *dev) if (!desc) goto err2; - for (; cfgno < ncfg; cfgno++) { + for (cfgno = 0; cfgno < ncfg; cfgno++) { /* We grab just the first descriptor so we know how long * the whole configuration is */ result = usb_get_descriptor(dev, USB_DT_CONFIG, cfgno, -- cgit v1.2.3-55-g7522