From f476ae9dab3234532d41d36beb4ba7be838fa786 Mon Sep 17 00:00:00 2001 From: Archit Taneja Date: Fri, 29 Jun 2012 14:37:03 +0530 Subject: OMAPDSS: APPLY: Remove DISPC writes to manager's lcd parameters in interface drivers Replace the DISPC fuctions used to configure LCD channel related manager parameters with dss_mgr_set_lcd_config() in APPLY. This function ensures that the DISPC registers are written at the right time by using the shadow register programming model. The LCD manager configurations is stored as a private data of manager in APPLY. It is treated as an extra info as it's the panel drivers which trigger this apply via interface drivers, and not a DSS2 user like omapfb or omapdrm. Storing LCD manager related properties in APPLY also prevents the need to refer to the panel connected to the manager for information. This helps in making the DSS driver less dependent on panel. A helper function is added to check whether the manager is LCD or TV. The direct DISPC register writes are removed from the interface drivers. Signed-off-by: Archit Taneja --- drivers/video/omap2/dss/dsi.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) (limited to 'drivers/video/omap2/dss/dsi.c') diff --git a/drivers/video/omap2/dss/dsi.c b/drivers/video/omap2/dss/dsi.c index f51df30d8c15..b07e8864f82f 100644 --- a/drivers/video/omap2/dss/dsi.c +++ b/drivers/video/omap2/dss/dsi.c @@ -4425,22 +4425,7 @@ static int dsi_display_init_dispc(struct omap_dss_device *dssdev) dsi_get_pixel_size(dssdev->panel.dsi_pix_fmt); dsi->mgr_config.lcden_sig_polarity = 0; - dispc_mgr_set_io_pad_mode(dsi->mgr_config.io_pad_mode); - - dispc_mgr_enable_stallmode(dssdev->manager->id, - dsi->mgr_config.stallmode); - dispc_mgr_enable_fifohandcheck(dssdev->manager->id, - dsi->mgr_config.fifohandcheck); - - dispc_mgr_set_clock_div(dssdev->manager->id, - &dsi->mgr_config.clock_info); - - dispc_mgr_set_tft_data_lines(dssdev->manager->id, - dsi->mgr_config.video_port_width); - - dispc_lcd_enable_signal_polarity(dsi->mgr_config.lcden_sig_polarity); - - dispc_mgr_set_lcd_type_tft(dssdev->manager->id); + dss_mgr_set_lcd_config(dssdev->manager, &dsi->mgr_config); return 0; err1: -- cgit v1.2.3-55-g7522