From 68ecfe2fe2e6c636bb7e2cf616e658e342e05362 Mon Sep 17 00:00:00 2001
From: Julia Lawall
Date: Fri, 8 Aug 2014 12:07:55 +0200
Subject: video: of: display_timing: delete unneeded test before of_node_put
Of_node_put supports NULL as its argument, so the initial test is not
necessary. Furthermore, native_mode cannot be NULL at this point.
Suggested by Uwe Kleine-König.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@@
expression e;
@@
-if (e)
of_node_put(e);
//
Signed-off-by: Julia Lawall
Signed-off-by: Tomi Valkeinen
---
drivers/video/of_display_timing.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
(limited to 'drivers/video')
diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c
index 987edf110038..339f831c8412 100644
--- a/drivers/video/of_display_timing.c
+++ b/drivers/video/of_display_timing.c
@@ -233,8 +233,7 @@ struct display_timings *of_get_display_timings(struct device_node *np)
return disp;
timingfail:
- if (native_mode)
- of_node_put(native_mode);
+ of_node_put(native_mode);
display_timings_release(disp);
entryfail:
kfree(disp);
--
cgit v1.2.3-55-g7522